Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259330

Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval

Show all headers | View raw

Hi,

On Fri, 2015-10-30 at 01:30 -0700, Tina Ruchandani wrote:
> Function stex_gettime uses 'struct timeval' whose tv_sec value
> will overflow on 32-bit systems in year 2038 and beyond. This patch
> replaces the use of struct timeval and do_gettimeofday with
> ktime_get_real_seconds, which returns a 64-bit seconds value.

Thanks for the conversion. Can you please check if other (scsi) drivers
have the same y2038 issues? A quick "git grep do_gettimeofday
drivers/scsi/  | wc -l" reveals 30 occurrences (of cause not all are
problematic).


Other than that
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESEND PATCH v3] scsi: stex: Remove use of struct timeval Tina Ruchandani <ruchandani.tina@gmail.com> - 2015-10-30 09:40 +0100
  Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval Johannes Thumshirn <jthumshirn@suse.de> - 2015-10-30 10:00 +0100
    Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval Tina Ruchandani <ruchandani.tina@gmail.com> - 2015-10-30 10:00 +0100
      Re: [Y2038] [RESEND PATCH v3] scsi: stex: Remove use of struct timeval Arnd Bergmann <arnd@arndb.de> - 2015-10-31 00:40 +0100
  Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval Hannes Reinecke <hare@suse.de> - 2015-10-30 13:00 +0100
    Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval Arnd Bergmann <arnd@arndb.de> - 2015-10-30 13:50 +0100

csiph-web