Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259229

Re: [for-next][PATCH 4/5] tracing: Check all tasks on each CPU when filtering pids

Show all headers | View raw

On Thu, Oct 29, 2015 at 03:07:58AM -0400, Steven Rostedt wrote:
>  static ssize_t
>  ftrace_event_pid_write(struct file *filp, const char __user *ubuf,
>  		       size_t cnt, loff_t *ppos)
> @@ -1711,6 +1727,12 @@ ftrace_event_pid_write(struct file *filp, const char __user *ubuf,
>  						 tr, INT_MAX);
>  		register_trace_prio_sched_wakeup(event_filter_pid_sched_wakeup_probe_post,
>  						 tr, 0);
> +
> +		/*
> +		 * Ignoring of pids is done at task switch. But we have to
> +		 * check for those tasks that are currently running.
> +		 */
> +		on_each_cpu(ignore_task_cpu, tr, 1);
>  	}
on_each_cpu(ignore_task_cpu, tr, 1); can be put outside of the else
block, then ignore_pid can be updated when appending pid, 
eg. echo 'xxx' >> set_event_pid, in case xxx is running on some cpu.
>  
>  	mutex_unlock(&event_mutex);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[for-next][PATCH 0/5] tracing: Addition of set_event_pid Steven Rostedt <rostedt@goodmis.org> - 2015-10-29 08:20 +0100
  [for-next][PATCH 1/5] tracepoint: Give priority to probes of tracepoints Steven Rostedt <rostedt@goodmis.org> - 2015-10-29 08:20 +0100
    Re: [for-next][PATCH 1/5] tracepoint: Give priority to probes of  tracepoints Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-10-29 19:00 +0100
      Re: [for-next][PATCH 1/5] tracepoint: Give priority to probes of  tracepoints Steven Rostedt <rostedt@goodmis.org> - 2015-10-30 21:30 +0100
        Re: [for-next][PATCH 1/5] tracepoint: Give priority to probes of  tracepoints Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-10-30 21:50 +0100
  [for-next][PATCH 4/5] tracing: Check all tasks on each CPU when filtering pids Steven Rostedt <rostedt@goodmis.org> - 2015-10-29 08:20 +0100
    Re: [for-next][PATCH 4/5] tracing: Check all tasks on each CPU when  filtering pids Jiaxing Wang <hello.wjx@gmail.com> - 2015-10-30 07:20 +0100
      Re: [for-next][PATCH 4/5] tracing: Check all tasks on each CPU when  filtering pids Steven Rostedt <rostedt@goodmis.org> - 2015-10-30 21:30 +0100
  [for-next][PATCH 3/5] tracing: Implement event pid filtering Steven Rostedt <rostedt@goodmis.org> - 2015-10-29 08:20 +0100
  [for-next][PATCH 2/5] tracing: Add set_event_pid directory for future use Steven Rostedt <rostedt@goodmis.org> - 2015-10-29 08:20 +0100
  [for-next][PATCH 5/5] tracing: Fix sparse RCU warning Steven Rostedt <rostedt@goodmis.org> - 2015-10-29 08:20 +0100

csiph-web