Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1258609

[for-next][PATCH 5/5] tracing: Fix sparse RCU warning

Show all headers | View raw

From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>

p_start() and p_stop() are seq_file functions that match. Teach sparse to
know that rcu_read_lock_sched() that is taken by p_start() is released by
p_stop.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/trace_events.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 2b7fccd499c6..fb0261e90acc 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -938,6 +938,7 @@ static void t_stop(struct seq_file *m, void *p)
 }
 
 static void *p_start(struct seq_file *m, loff_t *pos)
+	__acquires(RCU)
 {
 	struct trace_pid_list *pid_list;
 	struct trace_array *tr = m->private;
@@ -960,6 +961,7 @@ static void *p_start(struct seq_file *m, loff_t *pos)
 }
 
 static void p_stop(struct seq_file *m, void *p)
+	__releases(RCU)
 {
 	rcu_read_unlock_sched();
 	mutex_unlock(&event_mutex);
-- 
2.6.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[for-next][PATCH 0/5] tracing: Addition of set_event_pid Steven Rostedt <rostedt@goodmis.org> - 2015-10-29 08:20 +0100
  [for-next][PATCH 1/5] tracepoint: Give priority to probes of tracepoints Steven Rostedt <rostedt@goodmis.org> - 2015-10-29 08:20 +0100
    Re: [for-next][PATCH 1/5] tracepoint: Give priority to probes of  tracepoints Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-10-29 19:00 +0100
      Re: [for-next][PATCH 1/5] tracepoint: Give priority to probes of  tracepoints Steven Rostedt <rostedt@goodmis.org> - 2015-10-30 21:30 +0100
        Re: [for-next][PATCH 1/5] tracepoint: Give priority to probes of  tracepoints Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-10-30 21:50 +0100
  [for-next][PATCH 4/5] tracing: Check all tasks on each CPU when filtering pids Steven Rostedt <rostedt@goodmis.org> - 2015-10-29 08:20 +0100
    Re: [for-next][PATCH 4/5] tracing: Check all tasks on each CPU when  filtering pids Jiaxing Wang <hello.wjx@gmail.com> - 2015-10-30 07:20 +0100
      Re: [for-next][PATCH 4/5] tracing: Check all tasks on each CPU when  filtering pids Steven Rostedt <rostedt@goodmis.org> - 2015-10-30 21:30 +0100
  [for-next][PATCH 3/5] tracing: Implement event pid filtering Steven Rostedt <rostedt@goodmis.org> - 2015-10-29 08:20 +0100
  [for-next][PATCH 2/5] tracing: Add set_event_pid directory for future use Steven Rostedt <rostedt@goodmis.org> - 2015-10-29 08:20 +0100
  [for-next][PATCH 5/5] tracing: Fix sparse RCU warning Steven Rostedt <rostedt@goodmis.org> - 2015-10-29 08:20 +0100

csiph-web