Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108 GET_LINE_CTL bug

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108 GET_LINE_CTL bug
Date	Sat, 31 Oct 2015 16:00:02 +0100
Message-ID	<qpFNo-45K-7@gated-at.bofh.it> (permalink)
References	<qokrG-25s-45@gated-at.bofh.it> <qouKm-lA-13@gated-at.bofh.it> <qoPF7-5AP-3@gated-at.bofh.it> <qoVAS-KM-29@gated-at.bofh.it> <qpDiy-2I0-3@gated-at.bofh.it>
X-Original-To	Johan Hovold <johan@kernel.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=8Bq98KtVFgALAK7lAeFYTVMxEe+r5U9ogVj75nDMmzY=; b=PkUDcLxUzTh1oe2wDOHSwLg5zEnhNyKHhIjsUTsl6pzvtNq6ccrI2/zMJNUqQEUUzz 3DVfQOP7p7d+66Rr80nIgfpt+HGVBX7Pg/SkpFpdMs8Sa+22F8wM6ZjkcB1Sdc2kLJBz bRtQ+ONb6Wcb1pUoUJuwUGVSVZjsIiHiAHf9wf2uWJ7YOk8xtcHzS74QhUaLM0AQyjOA tsfEoGjvx/dUoeqddgZnJY11Qzr/avk5o8wF+gzMD94YnvVVzxP1RhpRxlX2uYofpo9J 8IapoT9oRzFtJSgCZOhvWY4rnDGcP3B9QIKZWAByhzpnleclEgADJkISIbuBrkZ4gKaQ eNUw==
MIME-Version	1.0
X-Received	by 10.60.65.68 with SMTP id v4mr9028385oes.84.1446303278269; Sat, 31 Oct 2015 07:54:38 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 31 Oct 2015 09:54:38 -0500
X-Original-Message-ID	<CAL_jEz_G9ro0M9t1n81mJ_S2to5DWQVHxVRhcEz4Wt8ZYqgJOQ@mail.gmail.com>
X-Original-References	<1445982814-11638-1-git-send-email-konstantin.shkolnyy@gmail.com> <20151028085126.GA28572@localhost> <20151029071923.GD32753@localhost> <CAL_jEz9PA9eLMXuX7MnAzPOwecCpSKZh54nNttudK=E=821J8Q@mail.gmail.com> <20151031121612.GC2636@localhost>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1260003

Show key headers only | View raw

On Sat, Oct 31, 2015 at 7:16 AM, Johan Hovold <johan@kernel.org> wrote:
> [ Please avoid top-posting. ]
>
> On Thu, Oct 29, 2015 at 08:39:04AM -0500, Konstantin Shkolnyy wrote:
>> I tested it on cp2102, cp2105 and cp2108.
>> I'm a little worried about that extra PURGE command, so I did several
>> manual tests on each with a standard PC serial port on the other end
>> of the cable.
>> - run several open/write/close iteration (the test that used to break
>> cp2108), observe data on the other end;
>> - open minicom and see that cp210x can still receive data from the other end.
>
> Sounds good.
>
> If this turns out to cause any problems, we can always enable this based
> on chip type, right? I saw something about a vendor request for that in
> your (silabs') vendor driver.

Yes, there is a register with the chip type.

[...]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108 GET_LINE_CTL bug Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-27 23:00 +0100
  Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108  GET_LINE_CTL bug Johan Hovold <johan@kernel.org> - 2015-10-28 10:00 +0100
    Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108  GET_LINE_CTL bug Johan Hovold <johan@kernel.org> - 2015-10-29 08:20 +0100
      Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108  GET_LINE_CTL bug Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-29 14:40 +0100
        Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108  GET_LINE_CTL bug Johan Hovold <johan@kernel.org> - 2015-10-31 13:20 +0100
          Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108  GET_LINE_CTL bug Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-31 16:00 +0100
          Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108  GET_LINE_CTL bug Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-11-03 14:30 +0100
            Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108  GET_LINE_CTL bug Johan Hovold <johan@kernel.org> - 2015-11-03 14:40 +0100

csiph-web