Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1258594

Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108 GET_LINE_CTL bug

Show all headers | View raw

On Wed, Oct 28, 2015 at 09:51:26AM +0100, Johan Hovold wrote:
> On Tue, Oct 27, 2015 at 04:53:34PM -0500, Konstantin Shkolnyy wrote:
> > cp2108 GET_LINE_CTL returns the 16-bit value with the 2 bytes swapped.
> > However, SET_LINE_CTL functions properly. When the driver tries to modify
> > the register, it reads it, modifies some bits and writes back. Because the
> > read bytes were swapped, this often results in an invalid value to be
> > written. In turn, this causes cp2108 respond with a stall. The stall
> > sometimes doesn't clear properly and cp2108 starts responding to following
> > valid commands also with stalls, effectively failing.
> > 
> > Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>

> I gave the series a really quick test on an cp2102-device I had lying
> around. I assume you verified the changes on some other older devices as
> well?

Did you test this series on the older device types as well?

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108 GET_LINE_CTL bug Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-27 23:00 +0100
  Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108  GET_LINE_CTL bug Johan Hovold <johan@kernel.org> - 2015-10-28 10:00 +0100
    Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108  GET_LINE_CTL bug Johan Hovold <johan@kernel.org> - 2015-10-29 08:20 +0100
      Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108  GET_LINE_CTL bug Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-10-29 14:40 +0100
        Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108  GET_LINE_CTL bug Johan Hovold <johan@kernel.org> - 2015-10-31 13:20 +0100

csiph-web