Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257592

Re: [PATCH 2/3] virtio_ring: Support DMA APIs

Show all headers | View raw

On Tue, Oct 27, 2015 at 07:13:56PM -0700, Andy Lutomirski wrote:
> On Tue, Oct 27, 2015 at 7:06 PM, Joerg Roedel <jroedel@suse.de> wrote:
> > Hi Andy,
> >
> > On Tue, Oct 27, 2015 at 06:17:09PM -0700, Andy Lutomirski wrote:
> >> From: Andy Lutomirski <luto@amacapital.net>
> >>
> >> virtio_ring currently sends the device (usually a hypervisor)
> >> physical addresses of its I/O buffers.  This is okay when DMA
> >> addresses and physical addresses are the same thing, but this isn't
> >> always the case.  For example, this never works on Xen guests, and
> >> it is likely to fail if a physical "virtio" device ever ends up
> >> behind an IOMMU or swiotlb.
> >
> > The overall code looks good, but I havn't seen and dma_sync* calls.
> > When swiotlb=force is in use this would break.
> >
> >> +             vq->vring.desc[head].addr = cpu_to_virtio64(_vq->vdev, vring_map_single(
> >> +                     vq,
> >> +                     desc, total_sg * sizeof(struct vring_desc),
> >> +                     DMA_TO_DEVICE));
> >
> 
> Are you talking about a dma_sync call on the descriptor ring itself?
> Isn't dma_alloc_coherent supposed to make that unnecessary?  I should
> move the allocation into the virtqueue code.
> 
> The docs suggest that I might need to "flush the processor's write
> buffers before telling devices to read that memory".  I'm not sure how
> to do that.

The write buffers should be flushed by the dma-api functions if
necessary.  For dma_alloc_coherent allocations you don't need to call
dma_sync*, but for the map_single/map_page/map_sg ones, as these might
be bounce-buffered.


	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] virtio_ring: Support DMA APIs Andy Lutomirski <luto@kernel.org> - 2015-10-28 02:20 +0100
  Re: [PATCH 2/3] virtio_ring: Support DMA APIs Joerg Roedel <jroedel@suse.de> - 2015-10-28 03:10 +0100
    Re: [PATCH 2/3] virtio_ring: Support DMA APIs Andy Lutomirski <luto@amacapital.net> - 2015-10-28 03:20 +0100
      Re: [PATCH 2/3] virtio_ring: Support DMA APIs Joerg Roedel <jroedel@suse.de> - 2015-10-28 03:30 +0100
        Re: [PATCH 2/3] virtio_ring: Support DMA APIs Andy Lutomirski <luto@amacapital.net> - 2015-10-28 06:20 +0100
  Re: [PATCH 2/3] virtio_ring: Support DMA APIs Christian Borntraeger <borntraeger@de.ibm.com> - 2015-10-28 03:30 +0100
    Re: [PATCH 2/3] virtio_ring: Support DMA APIs Andy Lutomirski <luto@amacapital.net> - 2015-10-28 06:10 +0100

csiph-web