Re: [PATCH v2] PM / suspend: replacing printk

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] PM / suspend: replacing printk
Date	2015-10-27 20:40 +0100
Message-ID	<qoiga-Mb-25@gated-at.bofh.it> (permalink)
References	<qnH6W-3es-15@gated-at.bofh.it> <qoi6u-J0-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2015-10-28 at 00:51 +0530, Saurabh Sengar wrote:
> replacing prink(s) with appropriate pr_info and pr_err

Removing the terminating newlines is likely incorrect.

> diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
[]
> @@ -245,7 +245,7 @@ static int suspend_test(int level)
>  {
>  #ifdef CONFIG_PM_DEBUG
>  	if (pm_test_level == level) {
> -		printk(KERN_INFO "suspend debug: Waiting for %d second(s).\n",
> +		pr_info("suspend debug: Waiting for %d second(s).",
>  				pm_test_delay);
>  		mdelay(pm_test_delay * 1000);
>  		return 1;
> @@ -317,7 +317,7 @@ static int suspend_enter(suspend_state_t state, bool *wakeup)
>  
>  	error = dpm_suspend_late(PMSG_SUSPEND);
>  	if (error) {
> -		printk(KERN_ERR "PM: late suspend of devices failed\n");
> +		pr_err("PM: late suspend of devices failed");
>  		goto Platform_finish;
>  	}
>  	error = platform_suspend_prepare_late(state);
> @@ -326,7 +326,7 @@ static int suspend_enter(suspend_state_t state, bool *wakeup)
>  
>  	error = dpm_suspend_noirq(PMSG_SUSPEND);
>  	if (error) {
> -		printk(KERN_ERR "PM: noirq suspend of devices failed\n");
> +		pr_err("PM: noirq suspend of devices failed");
>  		goto Platform_early_resume;
>  	}
>  	error = platform_suspend_prepare_noirq(state);



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] PM / suspend: replacing printk Saurabh Sengar <saurabh.truth@gmail.com> - 2015-10-27 20:30 +0100
  Re: [PATCH v2] PM / suspend: replacing printk Richard Weinberger <richard.weinberger@gmail.com> - 2015-10-27 20:30 +0100
    Re: [PATCH v2] PM / suspend: replacing printk Richard Weinberger <richard@nod.at> - 2015-10-27 20:40 +0100
  Re: [PATCH v2] PM / suspend: replacing printk Joe Perches <joe@perches.com> - 2015-10-27 20:40 +0100

csiph-web