Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1257161
| From | Richard Weinberger <richard@nod.at> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] PM / suspend: replacing printk |
| Date | 2015-10-27 20:40 +0100 |
| Message-ID | <qoiga-Mb-11@gated-at.bofh.it> (permalink) |
| References | <qnH6W-3es-15@gated-at.bofh.it> <qoi6u-J0-9@gated-at.bofh.it> <qoi6u-J0-33@gated-at.bofh.it> <qoiga-Mb-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Am 27.10.2015 um 20:32 schrieb Saurabh Sengar: > it fixes the checkpatch.pl <http://checkpatch.pl> warnings Don't get me wrong, but checkpatch.pl is only a script which makes suggestions. Especially as these are only warnings and not errors. IMHO the code is perfectly fine as is. Thanks, //richard > On Oct 28, 2015 12:56 AM, "Richard Weinberger" <richard.weinberger@gmail.com <mailto:richard.weinberger@gmail.com>> wrote: >> >> On Tue, Oct 27, 2015 at 8:21 PM, Saurabh Sengar <saurabh.truth@gmail.com <mailto:saurabh.truth@gmail.com>> wrote: >> > replacing prink(s) with appropriate pr_info and pr_err >> > >> > Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com <mailto:saurabh.truth@gmail.com>> >> > --- >> > kernel/power/suspend.c | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deletions(-) >> >> In which way does this patch improve the existing code? >> You describe what it does but not which problem it solves and >> why this patch is necessary. >> >> -- >> Thanks, >> //richard > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] PM / suspend: replacing printk Saurabh Sengar <saurabh.truth@gmail.com> - 2015-10-27 20:30 +0100
Re: [PATCH v2] PM / suspend: replacing printk Richard Weinberger <richard.weinberger@gmail.com> - 2015-10-27 20:30 +0100
Re: [PATCH v2] PM / suspend: replacing printk Richard Weinberger <richard@nod.at> - 2015-10-27 20:40 +0100
Re: [PATCH v2] PM / suspend: replacing printk Joe Perches <joe@perches.com> - 2015-10-27 20:40 +0100
csiph-web