Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1256787

Re: [PATCH] w1: w1_process() is not freezable kthread

From Evgeniy Polyakov <zbr@ioremap.net>
Newsgroups linux.kernel
Subject Re: [PATCH] w1: w1_process() is not freezable kthread
Date 2015-10-27 15:40 +0100
Message-ID <qodzQ-6jT-29@gated-at.bofh.it> (permalink)
References <qnIZ4-4nx-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi

26.10.2015, 08:53, "Jiri Kosina" <jikos@kernel.org>:
> From: Jiri Kosina <jkosina@suse.cz>
>
> w1_process() calls try_to_freeze(), but the thread doesn't mark itself
> freezable through set_freezable(), so the try_to_freeze() call is useless.

I believe it is better to mark it freezable, what do you think?
Its task is useless if anyone else goes sleeping, it should freeze too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] w1: w1_process() is not freezable kthread Jiri Kosina <jikos@kernel.org> - 2015-10-26 07:00 +0100
  Re: [PATCH] w1: w1_process() is not freezable kthread Evgeniy Polyakov <zbr@ioremap.net> - 2015-10-27 15:40 +0100
    Re: [PATCH] w1: w1_process() is not freezable kthread Jiri Kosina <jikos@kernel.org> - 2015-10-28 06:30 +0100

csiph-web