[PATCH] w1: w1_process() is not freezable kthread

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH] w1: w1_process() is not freezable kthread
Date	2015-10-26 07:00 +0100
Message-ID	<qnIZ4-4nx-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Jiri Kosina <jkosina@suse.cz>

w1_process() calls try_to_freeze(), but the thread doesn't mark itself 
freezable through set_freezable(), so the try_to_freeze() call is useless.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 drivers/w1/w1.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index c9a7ff6..89a7847 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -1147,7 +1147,6 @@ int w1_process(void *data)
 			jremain = 1;
 		}
 
-		try_to_freeze();
 		__set_current_state(TASK_INTERRUPTIBLE);
 
 		/* hold list_mutex until after interruptible to prevent loosing
-- 
2.1.2


-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] w1: w1_process() is not freezable kthread Jiri Kosina <jikos@kernel.org> - 2015-10-26 07:00 +0100
  Re: [PATCH] w1: w1_process() is not freezable kthread Evgeniy Polyakov <zbr@ioremap.net> - 2015-10-27 15:40 +0100
    Re: [PATCH] w1: w1_process() is not freezable kthread Jiri Kosina <jikos@kernel.org> - 2015-10-28 06:30 +0100

csiph-web