Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input controller

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input controller
Date	2015-10-29 00:50 +0100
Message-ID	<qoIDD-Si-17@gated-at.bofh.it> (permalink)
References	(3 earlier) <qmtpo-390-9@gated-at.bofh.it> <qmTtw-6YP-27@gated-at.bofh.it> <qocX8-5RG-21@gated-at.bofh.it> <qonpv-4h9-1@gated-at.bofh.it> <qoGit-7XK-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Oct 28, 2015 at 09:18:20PM +0000, Damien Horsley wrote:
> On 28/10/15 01:04, Mark Brown wrote:

> >> I think it also makes sense to keep the blocks consistent with each
> >> other. The spdif (out and in), and parallel out, all flush automatically
> >> when stopped, and the fifo for the i2s out block is cleared when the
> >> reset is asserted.

> > This seems like an issue that got missed in the other drivers then.  I'd
> > expect the trigger operation to be a minimal operation which starts and
> > stops the data transfer, not doing anything else.

> The spdif out, spdif in, and parallel out blocks auto-flush whenever
> they are stopped. It is not possible for software to prevent this behavior.

Oh, so this isn't the drivers doing this?  In that case it's fine for
them to do that, if it's what the hardware does it's what the hardware
does.  It sounded like you were saying that there was similar code in
the other drivers.

Thread

Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S  input controller Mark Brown <broonie@kernel.org> - 2015-10-19 19:50 +0200
  Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input  controller Damien Horsley <Damien.Horsley@imgtec.com> - 2015-10-22 21:10 +0200
    Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S  input controller Mark Brown <broonie@kernel.org> - 2015-10-24 01:00 +0200
      Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input  controller Damien Horsley <Damien.Horsley@imgtec.com> - 2015-10-27 15:00 +0100
        Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S  input controller Mark Brown <broonie@kernel.org> - 2015-10-28 02:10 +0100
          Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input  controller Damien Horsley <Damien.Horsley@imgtec.com> - 2015-10-28 22:20 +0100
            Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S  input controller Mark Brown <broonie@kernel.org> - 2015-10-29 00:50 +0100
              Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input  controller Damien Horsley <Damien.Horsley@imgtec.com> - 2015-10-29 16:50 +0100
                Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S  input controller Mark Brown <broonie@kernel.org> - 2015-10-30 02:30 +0100

csiph-web