Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input controller

From	Damien Horsley <Damien.Horsley@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input controller
Date	2015-10-28 22:20 +0100
Message-ID	<qoGit-7XK-5@gated-at.bofh.it> (permalink)
References	(2 earlier) <qlmJk-35z-37@gated-at.bofh.it> <qmtpo-390-9@gated-at.bofh.it> <qmTtw-6YP-27@gated-at.bofh.it> <qocX8-5RG-21@gated-at.bofh.it> <qonpv-4h9-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 28/10/15 01:04, Mark Brown wrote:
> On Tue, Oct 27, 2015 at 01:55:27PM +0000, Damien Horsley wrote:
>> On 23/10/15 23:57, Mark Brown wrote:
> 
>>> Shouldn't we be doing that flush on stream close instead?  If nothing
>>> else the flush is going to discard a bit of data if the stream is just
>>> paused.
> 
>> The FIFOs are only 8 frames in size, so I am not sure there is an
>> issue with these frames being lost.
> 
>> I think it also makes sense to keep the blocks consistent with each
>> other. The spdif (out and in), and parallel out, all flush automatically
>> when stopped, and the fifo for the i2s out block is cleared when the
>> reset is asserted.
> 
> This seems like an issue that got missed in the other drivers then.  I'd
> expect the trigger operation to be a minimal operation which starts and
> stops the data transfer, not doing anything else.
> 

The spdif out, spdif in, and parallel out blocks auto-flush whenever
they are stopped. It is not possible for software to prevent this behavior.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S  input controller Mark Brown <broonie@kernel.org> - 2015-10-19 19:50 +0200
  Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input  controller Damien Horsley <Damien.Horsley@imgtec.com> - 2015-10-22 21:10 +0200
    Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S  input controller Mark Brown <broonie@kernel.org> - 2015-10-24 01:00 +0200
      Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input  controller Damien Horsley <Damien.Horsley@imgtec.com> - 2015-10-27 15:00 +0100
        Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S  input controller Mark Brown <broonie@kernel.org> - 2015-10-28 02:10 +0100
          Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input  controller Damien Horsley <Damien.Horsley@imgtec.com> - 2015-10-28 22:20 +0100
            Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S  input controller Mark Brown <broonie@kernel.org> - 2015-10-29 00:50 +0100
              Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input  controller Damien Horsley <Damien.Horsley@imgtec.com> - 2015-10-29 16:50 +0100
                Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S  input controller Mark Brown <broonie@kernel.org> - 2015-10-30 02:30 +0100

csiph-web