Re: [PATCH 2/3] iio: light: lm3533-als: Print error message on invalid resistance

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] iio: light: lm3533-als: Print error message on invalid resistance
Date	2015-10-28 20:00 +0100
Message-ID	<qoE70-6pV-35@gated-at.bofh.it> (permalink)
References	<qny3E-6je-15@gated-at.bofh.it> <qny3E-6je-13@gated-at.bofh.it> <qohWO-F5-43@gated-at.bofh.it> <qoDND-6j4-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2015-10-28 at 11:37 -0700, Bjorn Andersson wrote:
> On Tue 27 Oct 12:18 PDT 2015, Joe Perches wrote:
> > On Sun, 2015-10-25 at 11:09 -0700, Bjorn Andersson wrote:
> > > Print an error message to indicate that invalid configuration data was
> > > provided in the platform_data, rather than just aborting initialization.
> > Perhaps it'd be nicer to show the 3 values.
> I do agree that it would be helpful to hint the developer about the
> expected range. The problem I see here though is that, in the case of
> devicetree we've now moved from resistance to a register value.
[]
> So would you be okay with not improving the message? Or would you like
> me to just move it into the code in patch 1 - and leave the
> platform_data case as it was (with a silent failure)?
[]
> > > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
> > []
> > > @@ -743,8 +743,10 @@ static int lm3533_als_set_resistor(struct lm3533_als *als, u8 val)
> > >  {
> > >  	int ret;
> > >  
> > > -	if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX)
> > > +	if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX) {
> > > +		dev_err(&als->pdev->dev, "invalid resistor value\n");
> > >  		return -EINVAL;
> > > +	};
> > >  

What I suggested was just a trivial proposal.
Whatever you do is fine with me.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] iio: light: lm3533-als: Print error message on invalid resistance Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-10-25 19:20 +0100
  Re: [PATCH 2/3] iio: light: lm3533-als: Print error message on  invalid resistance Joe Perches <joe@perches.com> - 2015-10-27 20:20 +0100
    Re: [PATCH 2/3] iio: light: lm3533-als: Print error message on  invalid resistance Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-10-28 19:40 +0100
      Re: [PATCH 2/3] iio: light: lm3533-als: Print error message on  invalid resistance Joe Perches <joe@perches.com> - 2015-10-28 20:00 +0100

csiph-web