[PATCH 2/3] iio: light: lm3533-als: Print error message on invalid resistance

From	Bjorn Andersson <bjorn.andersson@sonymobile.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/3] iio: light: lm3533-als: Print error message on invalid resistance
Date	2015-10-25 19:20 +0100
Message-ID	<qny3E-6je-13@gated-at.bofh.it> (permalink)
References	<qny3E-6je-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Print an error message to indicate that invalid configuration data was
provided in the platform_data, rather than just aborting initialization.

Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---

This patch can be picked independently of the other 2, but included in the
series for "completeness".

 drivers/iio/light/lm3533-als.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
index 076bc46fad03..e56937c40a18 100644
--- a/drivers/iio/light/lm3533-als.c
+++ b/drivers/iio/light/lm3533-als.c
@@ -743,8 +743,10 @@ static int lm3533_als_set_resistor(struct lm3533_als *als, u8 val)
 {
 	int ret;
 
-	if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX)
+	if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX) {
+		dev_err(&als->pdev->dev, "invalid resistor value\n");
 		return -EINVAL;
+	};
 
 	ret = lm3533_write(als->lm3533, LM3533_REG_ALS_RESISTOR_SELECT, val);
 	if (ret) {
-- 
2.4.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] iio: light: lm3533-als: Print error message on invalid resistance Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-10-25 19:20 +0100
  Re: [PATCH 2/3] iio: light: lm3533-als: Print error message on  invalid resistance Joe Perches <joe@perches.com> - 2015-10-27 20:20 +0100
    Re: [PATCH 2/3] iio: light: lm3533-als: Print error message on  invalid resistance Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-10-28 19:40 +0100
      Re: [PATCH 2/3] iio: light: lm3533-als: Print error message on  invalid resistance Joe Perches <joe@perches.com> - 2015-10-28 20:00 +0100

csiph-web