Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1256563

[PATCH 2/3] megaraid_sas: Convert printk to printk_<level>

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Weidong Wang <wangweidong1@huawei.com>
Newsgroups linux.kernel
Subject [PATCH 2/3] megaraid_sas: Convert printk to printk_<level>
Date Tue, 27 Oct 2015 09:30:02 +0100
Message-ID <qo7NM-2U1-25@gated-at.bofh.it> (permalink)
References <qo7NM-2U1-21@gated-at.bofh.it>
X-Original-To <kashyap.desai@avagotech.com>, <sumit.saxena@avagotech.com>, <uday.lingala@avagotech.com>, <JBottomley@odin.com>
X-Mailer git-send-email 1.8.1.msysgit.1
MIME-Version 1.0
Content-Type text/plain
X-Originating-IP [10.177.21.100]
X-Cfilter-Loop Reflected
X-Mirapoint-Virus-Rapid-Raw score=unknown(0), refid=str=0001.0A020202.562F3562.002B,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID 4712e4a2d891774e0de6601161be8796
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 84
Organization linux.* mail to news gateway
X-Original-Cc <megaraidlinux.pdl@avagotech.com>, <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <wangweidong1@huawei.com>
X-Original-Date Tue, 27 Oct 2015 16:26:14 +0800
X-Original-Message-ID <1445934375-17784-3-git-send-email-wangweidong1@huawei.com>
X-Original-References <1445934375-17784-1-git-send-email-wangweidong1@huawei.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1256563

Show key headers only | View raw


Reduce object size a little by using pr_<level>
calls instead of printk(KERN_<LEVEL>.

Signed-off-by: Weidong Wang <wangweidong1@huawei.com>
---
 drivers/scsi/megaraid/megaraid_sas_base.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index ed9846d..2287aa1 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -5889,7 +5889,7 @@ static int megasas_mgmt_fasync(int fd, struct file *filep, int mode)
 		return 0;
 	}
 
-	printk(KERN_DEBUG "megasas: fasync_helper failed [%d]\n", rc);
+	pr_debug("megasas: fasync_helper failed [%d]\n", rc);
 
 	return rc;
 }
@@ -6233,7 +6233,7 @@ static int megasas_mgmt_ioctl_aen(struct file *file, unsigned long arg)
 	u32 wait_time = MEGASAS_RESET_WAIT_TIME;
 
 	if (file->private_data != file) {
-		printk(KERN_DEBUG "megasas: fasync_helper was not "
+		pr_debug("megasas: fasync_helper was not "
 		       "called first\n");
 		return -EINVAL;
 	}
@@ -6355,7 +6355,7 @@ static int megasas_mgmt_compat_ioctl_fw(struct file *file, unsigned long arg)
 
 	if (copy_in_user(&cioc->frame.hdr.cmd_status,
 			 &ioc->frame.hdr.cmd_status, sizeof(u8))) {
-		printk(KERN_DEBUG "megasas: error copy_in_user cmd_status\n");
+		pr_debug("megasas: error copy_in_user cmd_status\n");
 		return -EFAULT;
 	}
 	return error;
@@ -6455,7 +6455,7 @@ megasas_sysfs_set_dbg_lvl(struct device_driver *dd, const char *buf, size_t coun
 	int retval = count;
 
 	if (sscanf(buf, "%u", &megasas_dbg_lvl) < 1) {
-		printk(KERN_ERR "megasas: could not set dbg_lvl\n");
+		pr_err("megasas: could not set dbg_lvl\n");
 		retval = -EINVAL;
 	}
 	return retval;
@@ -6480,7 +6480,7 @@ megasas_aen_polling(struct work_struct *work)
 	int error;
 
 	if (!instance) {
-		printk(KERN_ERR "invalid instance!\n");
+		pr_err("invalid instance!\n");
 		kfree(ev);
 		return;
 	}
@@ -6740,7 +6740,7 @@ static int __init megasas_init(void)
 	rval = register_chrdev(0, "megaraid_sas_ioctl", &megasas_mgmt_fops);
 
 	if (rval < 0) {
-		printk(KERN_DEBUG "megasas: failed to open device node\n");
+		pr_debug("megasas: failed to open device node\n");
 		return rval;
 	}
 
@@ -6752,7 +6752,7 @@ static int __init megasas_init(void)
 	rval = pci_register_driver(&megasas_pci_driver);
 
 	if (rval) {
-		printk(KERN_DEBUG "megasas: PCI hotplug registration failed \n");
+		pr_debug("megasas: PCI hotplug registration failed \n");
 		goto err_pcidrv;
 	}
 
-- 
1.9.0


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] megaraid_sas: copule of fixes Weidong Wang <wangweidong1@huawei.com> - 2015-10-27 09:30 +0100
  [PATCH 3/3] megaraid_sas: return -ENOMEM when create DMA pool for cmd frames failed Weidong Wang <wangweidong1@huawei.com> - 2015-10-27 09:30 +0100
    Re: [PATCH 3/3] megaraid_sas: return -ENOMEM when create DMA pool  for cmd frames failed Johannes Thumshirn <jthumshirn@suse.de> - 2015-10-27 11:20 +0100
  [PATCH 2/3] megaraid_sas: Convert printk to printk_<level> Weidong Wang <wangweidong1@huawei.com> - 2015-10-27 09:30 +0100
    Re: [PATCH 2/3] megaraid_sas: Convert printk to printk_<level> Johannes Thumshirn <jthumshirn@suse.de> - 2015-10-27 11:30 +0100
    Re: [PATCH 2/3] megaraid_sas: Convert printk to printk_<level> Joe Perches <joe@perches.com> - 2015-10-27 20:40 +0100
  [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level> Weidong Wang <wangweidong1@huawei.com> - 2015-10-27 09:30 +0100
    Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level> Johannes Thumshirn <jthumshirn@suse.de> - 2015-10-27 11:30 +0100
      RE: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level> Kashyap Desai <kashyap.desai@avagotech.com> - 2015-10-27 11:40 +0100
        Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level> Weidong Wang <wangweidong1@huawei.com> - 2015-10-28 03:40 +0100
    Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level> Joe Perches <joe@perches.com> - 2015-10-27 20:40 +0100
      Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level> Weidong Wang <wangweidong1@huawei.com> - 2015-10-28 03:10 +0100

csiph-web