Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257583

Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level>

Show all headers | View raw

On 2015/10/28 3:35, Joe Perches wrote:
> On Tue, 2015-10-27 at 16:26 +0800, Weidong Wang wrote:
>> Reduce object size a little by using dev_<level>
>> calls instead of dev_printk(KERN_<LEVEL>.
> 
> This is also not the same output.
> 
> dev_printk(KERN_DEBUG vs dev_dbg has the same
> behavior as printk(KERN_DEBUG vs pr_debug
> 

yep, You are right.

As Kashyap said, these two patches(Covert [dev_]printk to [dev|pr]_<level>) may
introduced conflicts to their working for megaraid_sas.
So just ignore these two patches.

Regards,
Weidong

>> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> []
>> @@ -1884,7 +1884,7 @@ static int megasas_get_ld_vf_affiliation_111(struct megasas_instance *instance,
>>  	cmd = megasas_get_cmd(instance);
>>  
>>  	if (!cmd) {
>> -		dev_printk(KERN_DEBUG, &instance->pdev->dev, "megasas_get_ld_vf_affiliation_111:"
>> +		dev_dbg(&instance->pdev->dev, "megasas_get_ld_vf_affiliation_111:"
>>  		       "Failed to get cmd for scsi%d\n",
>>  			instance->host->host_no);
>>  		return -ENOMEM;
> []
>> @@ -5243,7 +5243,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
>>  					     &instance->consumer_h);
>>  
>>  		if (!instance->producer || !instance->consumer) {
>> -			dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate"
>> +			dev_dbg(&pdev->dev, "Failed to allocate"
>>  			       "memory for producer, consumer\n");
> 
> Note the lack of a space between coalesced string segment words.
> That's one of the reasons to coalesce them.
> 
> 
> 
> .
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] megaraid_sas: copule of fixes Weidong Wang <wangweidong1@huawei.com> - 2015-10-27 09:30 +0100
  [PATCH 3/3] megaraid_sas: return -ENOMEM when create DMA pool for cmd frames failed Weidong Wang <wangweidong1@huawei.com> - 2015-10-27 09:30 +0100
    Re: [PATCH 3/3] megaraid_sas: return -ENOMEM when create DMA pool  for cmd frames failed Johannes Thumshirn <jthumshirn@suse.de> - 2015-10-27 11:20 +0100
  [PATCH 2/3] megaraid_sas: Convert printk to printk_<level> Weidong Wang <wangweidong1@huawei.com> - 2015-10-27 09:30 +0100
    Re: [PATCH 2/3] megaraid_sas: Convert printk to printk_<level> Johannes Thumshirn <jthumshirn@suse.de> - 2015-10-27 11:30 +0100
    Re: [PATCH 2/3] megaraid_sas: Convert printk to printk_<level> Joe Perches <joe@perches.com> - 2015-10-27 20:40 +0100
  [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level> Weidong Wang <wangweidong1@huawei.com> - 2015-10-27 09:30 +0100
    Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level> Johannes Thumshirn <jthumshirn@suse.de> - 2015-10-27 11:30 +0100
      RE: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level> Kashyap Desai <kashyap.desai@avagotech.com> - 2015-10-27 11:40 +0100
        Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level> Weidong Wang <wangweidong1@huawei.com> - 2015-10-28 03:40 +0100
    Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level> Joe Perches <joe@perches.com> - 2015-10-27 20:40 +0100
      Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level> Weidong Wang <wangweidong1@huawei.com> - 2015-10-28 03:10 +0100

csiph-web