Re: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM

From	Toshi Kani <toshi.kani@hpe.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM
Date	2015-10-26 17:40 +0100
Message-ID	<qnSYr-26p-17@gated-at.bofh.it> (permalink)
References	<qnRzk-1mw-15@gated-at.bofh.it> <qnSOL-23f-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2015-10-26 at 16:26 +0000, Luck, Tony wrote:
> -	pfn = PFN_DOWN(param1 & param2);
> -	if (!page_is_ram(pfn) || ((param2 & PAGE_MASK) != PAGE_MASK))
> +	base_addr = param1 & param2;
> +	size = (~param2) + 1;
> 
> We expect the user will supply us with param2 in the form 0xffffffff[fec8]00000
> with various numbers of leading 'f' and trailing '0' ... but I don't think we actually
> check that anywhere.  But we have a bunch of places that assume it is OK, including
> this new one.
> 
> It's time to fix that.  Maybe even provide a default 0xfffffffffffff000 so I can save 
> myself some typing?

+       if (((region_intersects_ram(base_addr, size) != REGION_INTERSECTS) &&
+            (region_intersects_pmem(base_addr, size) != REGION_INTERSECTS)) ||
+           ((param2 & PAGE_MASK) != PAGE_MASK))
                return -EINVAL;

The 3rd condition check makes sure that the param2 mask is the page size or less.  So, I
think we are OK on this.

Thanks,
-Toshi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM Toshi Kani <toshi.kani@hpe.com> - 2015-10-26 16:10 +0100
  RE: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error  injection to NVDIMM "Luck, Tony" <tony.luck@intel.com> - 2015-10-26 17:30 +0100
    Re: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error  injection to NVDIMM Toshi Kani <toshi.kani@hpe.com> - 2015-10-26 17:40 +0100
      RE: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error  injection to NVDIMM "Luck, Tony" <tony.luck@intel.com> - 2015-10-26 17:50 +0100
        Re: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error  injection to NVDIMM Toshi Kani <toshi.kani@hpe.com> - 2015-10-26 18:00 +0100

csiph-web