Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1256145
| From | "Luck, Tony" <tony.luck@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM |
| Date | 2015-10-26 17:30 +0100 |
| Message-ID | <qnSOL-23f-15@gated-at.bofh.it> (permalink) |
| References | <qnRzk-1mw-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
- pfn = PFN_DOWN(param1 & param2); - if (!page_is_ram(pfn) || ((param2 & PAGE_MASK) != PAGE_MASK)) + base_addr = param1 & param2; + size = (~param2) + 1; We expect the user will supply us with param2 in the form 0xffffffff[fec8]00000 with various numbers of leading 'f' and trailing '0' ... but I don't think we actually check that anywhere. But we have a bunch of places that assume it is OK, including this new one. It's time to fix that. Maybe even provide a default 0xfffffffffffff000 so I can save myself some typing? -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM Toshi Kani <toshi.kani@hpe.com> - 2015-10-26 16:10 +0100
RE: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM "Luck, Tony" <tony.luck@intel.com> - 2015-10-26 17:30 +0100
Re: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM Toshi Kani <toshi.kani@hpe.com> - 2015-10-26 17:40 +0100
RE: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM "Luck, Tony" <tony.luck@intel.com> - 2015-10-26 17:50 +0100
Re: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM Toshi Kani <toshi.kani@hpe.com> - 2015-10-26 18:00 +0100
csiph-web