Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1255147

Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI

Show all headers | View raw

On Sat, 24 Oct 2015 09:13:28 +0200
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> Or simply
> 
> bus_gates {
> 	clocks = <&ahb1>, <&ahb2>;
> 	clock-indices = <5>, <6>, <8>, ...
> 	clock-output-names = "bus_ce", "bus_dma", "bus_mmc0"
> };

I don't understand: the apb1, apb2, ahb1 and ahb2 clocks may be
programmed independently to different frequencies and you have to know
which of them is the parent of each leaf clock.

So, either you hard-code the parents as Jens did in a first proposal,
or you define the full list of parents in the DT as in the last
proposal, or you use a container per parent in the DT as I proposed.

There could be an other solution using the output clock name to define
the parent clock:

bus_gates {
	clocks = <&ahb1>, <&ahb2>, <&apb1>, <&apb2>;
	clock-indices = <5>, <6>, <8>, ...
	clock-output-names = "ahb1_ce", "ahb1_dma", "ahb1_mmc0"
};

with the documentation:

	"the clocks MUST be defined in order: ahb1, ahb2, apb1, apb2."

and the code

	if (strncmp(clock_name, "ahb1", 4) == 0)
		clk_parent = of_clk_get_parent_name(node, 0);
	else if (..)

but it seems a bit hacky.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/6] reset: sunxi: Add compatible for Allwinner H3 bus resets Jens Kuske <jenskuske@gmail.com> - 2015-10-21 18:30 +0200
  [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jens Kuske <jenskuske@gmail.com> - 2015-10-21 18:30 +0200
    Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-22 10:10 +0200
      Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jean-Francois Moine <moinejf@free.fr> - 2015-10-22 10:40 +0200
        Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-22 10:50 +0200
          Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jean-Francois Moine <moinejf@free.fr> - 2015-10-22 11:00 +0200
            Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-22 11:20 +0200
              Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jens Kuske <jenskuske@gmail.com> - 2015-10-22 14:00 +0200
                Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-23 20:10 +0200
    Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jean-Francois Moine <moinejf@free.fr> - 2015-10-22 19:40 +0200
    Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-23 20:20 +0200
      Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jean-Francois Moine <moinejf@free.fr> - 2015-10-23 21:30 +0200
        Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-24 09:20 +0200
          Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jean-Francois Moine <moinejf@free.fr> - 2015-10-24 10:50 +0200
            Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-26 22:10 +0100
              Re: [linux-sunxi] Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3  DTSI Hans de Goede <hdegoede@redhat.com> - 2015-10-27 09:20 +0100
      Re: [linux-sunxi] Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3  DTSI Hans de Goede <hdegoede@redhat.com> - 2015-10-24 10:50 +0200
        Re: [linux-sunxi] Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3  DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-26 22:10 +0100
  Re: [PATCH 4/6] reset: sunxi: Add compatible for Allwinner H3 bus  resets Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-22 10:00 +0200
    Re: [PATCH 4/6] reset: sunxi: Add compatible for Allwinner H3 bus  resets Jens Kuske <jenskuske@gmail.com> - 2015-10-27 18:00 +0100

csiph-web