Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1254833
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI |
| Date | 2015-10-23 20:20 +0200 |
| Message-ID | <qmP6A-Po-45@gated-at.bofh.it> (permalink) |
| References | <qm4r0-8qy-7@gated-at.bofh.it> <qm4r3-8qy-77@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Wed, Oct 21, 2015 at 06:20:27PM +0200, Jens Kuske wrote:
> + bus_gates: clk@01c20060 {
> + #clock-cells = <1>;
> + compatible = "allwinner,sun8i-h3-bus-gates-clk";
> + reg = <0x01c20060 0x14>;
> + clock-indices = <5>, <6>, <8>,
> + <9>, <10>, <13>,
> + <14>, <17>, <18>,
> + <19>, <20>,
> + <21>, <23>,
> + <24>, <25>,
> + <26>, <27>,
> + <28>, <29>,
> + <30>, <31>, <32>,
> + <35>, <36>, <37>,
> + <40>, <41>, <43>,
> + <44>, <52>, <53>,
> + <54>, <64>,
> + <65>, <69>, <72>,
> + <76>, <77>, <78>,
> + <96>, <97>, <98>,
> + <112>, <113>,
> + <114>, <115>, <116>,
> + <128>, <135>;
> + clocks = <&ahb1>, <&ahb1>, <&ahb1>,
> + <&ahb1>, <&ahb1>, <&ahb1>,
> + <&ahb1>, <&ahb2>, <&ahb1>,
> + <&ahb1>, <&ahb1>,
> + <&ahb1>, <&ahb1>,
> + <&ahb1>, <&ahb1>,
> + <&ahb1>, <&ahb1>,
> + <&ahb1>, <&ahb2>,
> + <&ahb2>, <&ahb2>, <&ahb1>,
> + <&ahb1>, <&ahb1>, <&ahb1>,
> + <&ahb1>, <&ahb1>, <&ahb1>,
> + <&ahb1>, <&ahb1>, <&ahb1>,
> + <&ahb1>, <&apb1>,
> + <&apb1>, <&apb1>, <&apb1>,
> + <&apb1>, <&apb1>, <&apb1>,
> + <&apb2>, <&apb2>, <&apb2>,
> + <&apb2>, <&apb2>,
> + <&apb2>, <&apb2>, <&apb2>,
> + <&ahb1>, <&ahb1>;
This is not really what I had in mind...
This IP has 2 parents, and only two parents. The mapping between the
IPs should be done in the driver itself, not in the DT where it is
very error prone and barely readable.
And note that I never have expected you to use clk-simple-gates
either. This is a complicated clock, unlike the other we've seen so
far, it definitely deserves a driver of its own.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 4/6] reset: sunxi: Add compatible for Allwinner H3 bus resets Jens Kuske <jenskuske@gmail.com> - 2015-10-21 18:30 +0200
[PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jens Kuske <jenskuske@gmail.com> - 2015-10-21 18:30 +0200
Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-22 10:10 +0200
Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jean-Francois Moine <moinejf@free.fr> - 2015-10-22 10:40 +0200
Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-22 10:50 +0200
Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jean-Francois Moine <moinejf@free.fr> - 2015-10-22 11:00 +0200
Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-22 11:20 +0200
Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jens Kuske <jenskuske@gmail.com> - 2015-10-22 14:00 +0200
Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-23 20:10 +0200
Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jean-Francois Moine <moinejf@free.fr> - 2015-10-22 19:40 +0200
Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-23 20:20 +0200
Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jean-Francois Moine <moinejf@free.fr> - 2015-10-23 21:30 +0200
Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-24 09:20 +0200
Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jean-Francois Moine <moinejf@free.fr> - 2015-10-24 10:50 +0200
Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-26 22:10 +0100
Re: [linux-sunxi] Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Hans de Goede <hdegoede@redhat.com> - 2015-10-27 09:20 +0100
Re: [linux-sunxi] Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Hans de Goede <hdegoede@redhat.com> - 2015-10-24 10:50 +0200
Re: [linux-sunxi] Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-26 22:10 +0100
Re: [PATCH 4/6] reset: sunxi: Add compatible for Allwinner H3 bus resets Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-22 10:00 +0200
Re: [PATCH 4/6] reset: sunxi: Add compatible for Allwinner H3 bus resets Jens Kuske <jenskuske@gmail.com> - 2015-10-27 18:00 +0100
csiph-web