Re: [REPOST PATCH] ftrace: Calculate the correct dyn_ftrace number to report to the userspace

Path	csiph.com!news.mixmin.net!weretis.net!feeder1.news.weretis.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod
From	Minfei Huang <mnfhuang@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [REPOST PATCH] ftrace: Calculate the correct dyn_ftrace number to report to the userspace
Date	Thu, 22 Oct 2015 07:20:02 +0200
Message-ID	<qmgs9-R6-1@gated-at.bofh.it> (permalink)
References	<q9nKP-1iB-25@gated-at.bofh.it> <qk2Wm-HG-17@gated-at.bofh.it>
X-Original-To	Steven Rostedt <rostedt@goodmis.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=VYSFRH5bwCUoD7UGBbAjrZwNl+MsxdZ+nYao+0D0PYU=; b=FzsbcbhK5FSxe5dYPGQxRLnK8Wzdx9mOwJDJB31Hbk1RaYIitmLI8A0diSiXoeWUEp fkbDVkywHUYgfAtcM/94oOMkiK6ChYeF9bemEuHKzEFEH8Pr73toGbwhMPi6whr3M+/b LirNrnVKc+au1RR+Tl2ptKdF812CDapOJrjD4ZSeLigxIiBvdMn7WQQiOM51LBV87Csp kKuWvfEhMrFh4iocnTvHmbI7rs5Fhu7J1g9QKUUzjIU2Rn7+A2lT7ljtSZdEuBXx3Djj wyHwpjOK1kBIZb6QgjKKXFc7vYsz592Ebt8kl7ngwV5yE31x5Vok3H+9Gbp3dDB7WvU4 EaJg==
X-Received	by 10.68.96.67 with SMTP id dq3mr15022793pbb.161.1445490850932; Wed, 21 Oct 2015 22:14:10 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	70
Organization	linux.* mail to news gateway
X-Original-Cc	mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, mhuang@redhat.com
X-Original-Date	Thu, 22 Oct 2015 13:14:07 +0800
X-Original-Message-ID	<20151022051407.GA9292@t420s.redhat.com>
X-Original-References	<1442420382-13130-1-git-send-email-mnfhuang@gmail.com> <20151015222545.45a22b7e@grimm.local.home>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1253485

Show key headers only | View raw

On 10/15/15 at 10:25pm, Steven Rostedt wrote:
> On Thu, 17 Sep 2015 00:19:42 +0800
> Minfei Huang <mnfhuang@gmail.com> wrote:
> 
> > Now, ftrace only calculate the dyn_ftrace number in the adding
> > breakpoint loop, not in adding update and finish update loop.
> > 
> > Calculate the correct dyn_ftrace, once ftrace reports the failure message
> > to the userspace.
> > 
> 
> Bah, your emails got lost in my Inbox. Sorry about that.
> 
> I'll make an effort to look at this first thing tomorrow.

Ping. Any comment is appreciate.

Thanks
Minfei

> 
> [ Cc'ing myself to remind me ]
> 
> -- Steve
> 
> > Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> > ---
> >  arch/x86/kernel/ftrace.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
> > index 8b7b0a5..311bcf3 100644
> > --- a/arch/x86/kernel/ftrace.c
> > +++ b/arch/x86/kernel/ftrace.c
> > @@ -556,6 +556,7 @@ void ftrace_replace_code(int enable)
> >  	run_sync();
> >  
> >  	report = "updating code";
> > +	count = 0;
> >  
> >  	for_ftrace_rec_iter(iter) {
> >  		rec = ftrace_rec_iter_record(iter);
> > @@ -563,11 +564,13 @@ void ftrace_replace_code(int enable)
> >  		ret = add_update(rec, enable);
> >  		if (ret)
> >  			goto remove_breakpoints;
> > +		count++;
> >  	}
> >  
> >  	run_sync();
> >  
> >  	report = "removing breakpoints";
> > +	count = 0;
> >  
> >  	for_ftrace_rec_iter(iter) {
> >  		rec = ftrace_rec_iter_record(iter);
> > @@ -575,6 +578,7 @@ void ftrace_replace_code(int enable)
> >  		ret = finish_update(rec, enable);
> >  		if (ret)
> >  			goto remove_breakpoints;
> > +		count++;
> >  	}
> >  
> >  	run_sync();
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [REPOST PATCH] ftrace: Calculate the correct dyn_ftrace number  to report to the userspace Minfei Huang <mnfhuang@gmail.com> - 2015-10-22 07:20 +0200
  Re: [REPOST PATCH] ftrace: Calculate the correct dyn_ftrace number  to report to the userspace Steven Rostedt <rostedt@goodmis.org> - 2015-10-22 19:10 +0200
  Re: [REPOST PATCH] ftrace: Calculate the correct dyn_ftrace number  to report to the userspace Steven Rostedt <rostedt@goodmis.org> - 2015-10-22 21:50 +0200

csiph-web