Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1253485 > unrolled thread
| Started by | Minfei Huang <mnfhuang@gmail.com> |
|---|---|
| First post | 2015-10-22 07:20 +0200 |
| Last post | 2015-10-22 21:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [REPOST PATCH] ftrace: Calculate the correct dyn_ftrace number to report to the userspace Minfei Huang <mnfhuang@gmail.com> - 2015-10-22 07:20 +0200
Re: [REPOST PATCH] ftrace: Calculate the correct dyn_ftrace number to report to the userspace Steven Rostedt <rostedt@goodmis.org> - 2015-10-22 19:10 +0200
Re: [REPOST PATCH] ftrace: Calculate the correct dyn_ftrace number to report to the userspace Steven Rostedt <rostedt@goodmis.org> - 2015-10-22 21:50 +0200
| From | Minfei Huang <mnfhuang@gmail.com> |
|---|---|
| Date | 2015-10-22 07:20 +0200 |
| Subject | Re: [REPOST PATCH] ftrace: Calculate the correct dyn_ftrace number to report to the userspace |
| Message-ID | <qmgs9-R6-1@gated-at.bofh.it> |
On 10/15/15 at 10:25pm, Steven Rostedt wrote:
> On Thu, 17 Sep 2015 00:19:42 +0800
> Minfei Huang <mnfhuang@gmail.com> wrote:
>
> > Now, ftrace only calculate the dyn_ftrace number in the adding
> > breakpoint loop, not in adding update and finish update loop.
> >
> > Calculate the correct dyn_ftrace, once ftrace reports the failure message
> > to the userspace.
> >
>
> Bah, your emails got lost in my Inbox. Sorry about that.
>
> I'll make an effort to look at this first thing tomorrow.
Ping. Any comment is appreciate.
Thanks
Minfei
>
> [ Cc'ing myself to remind me ]
>
> -- Steve
>
> > Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> > ---
> > arch/x86/kernel/ftrace.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
> > index 8b7b0a5..311bcf3 100644
> > --- a/arch/x86/kernel/ftrace.c
> > +++ b/arch/x86/kernel/ftrace.c
> > @@ -556,6 +556,7 @@ void ftrace_replace_code(int enable)
> > run_sync();
> >
> > report = "updating code";
> > + count = 0;
> >
> > for_ftrace_rec_iter(iter) {
> > rec = ftrace_rec_iter_record(iter);
> > @@ -563,11 +564,13 @@ void ftrace_replace_code(int enable)
> > ret = add_update(rec, enable);
> > if (ret)
> > goto remove_breakpoints;
> > + count++;
> > }
> >
> > run_sync();
> >
> > report = "removing breakpoints";
> > + count = 0;
> >
> > for_ftrace_rec_iter(iter) {
> > rec = ftrace_rec_iter_record(iter);
> > @@ -575,6 +578,7 @@ void ftrace_replace_code(int enable)
> > ret = finish_update(rec, enable);
> > if (ret)
> > goto remove_breakpoints;
> > + count++;
> > }
> >
> > run_sync();
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Date | 2015-10-22 19:10 +0200 |
| Message-ID | <qmrxf-pB-5@gated-at.bofh.it> |
| In reply to | #1253485 |
On Thu, 22 Oct 2015 13:14:07 +0800 Minfei Huang <mnfhuang@gmail.com> wrote: > On 10/15/15 at 10:25pm, Steven Rostedt wrote: > > On Thu, 17 Sep 2015 00:19:42 +0800 > > Minfei Huang <mnfhuang@gmail.com> wrote: > > > > > Now, ftrace only calculate the dyn_ftrace number in the adding > > > breakpoint loop, not in adding update and finish update loop. > > > > > > Calculate the correct dyn_ftrace, once ftrace reports the failure message > > > to the userspace. > > > > > > > Bah, your emails got lost in my Inbox. Sorry about that. > > > > I'll make an effort to look at this first thing tomorrow. > > Ping. Any comment is appreciate. > > Thanks > Minfei > > > > > [ Cc'ing myself to remind me ] > > And I still forgot :-/ OK, I'm looking at it now. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Date | 2015-10-22 21:50 +0200 |
| Message-ID | <qmu26-3Sv-17@gated-at.bofh.it> |
| In reply to | #1253485 |
On Thu, 22 Oct 2015 13:14:07 +0800 Minfei Huang <mnfhuang@gmail.com> wrote: > On 10/15/15 at 10:25pm, Steven Rostedt wrote: > > On Thu, 17 Sep 2015 00:19:42 +0800 > > Minfei Huang <mnfhuang@gmail.com> wrote: > > > > > Now, ftrace only calculate the dyn_ftrace number in the adding > > > breakpoint loop, not in adding update and finish update loop. > > > > > > Calculate the correct dyn_ftrace, once ftrace reports the failure message > > > to the userspace. > > > > > > > Bah, your emails got lost in my Inbox. Sorry about that. > > > > I'll make an effort to look at this first thing tomorrow. > > Ping. Any comment is appreciate. > Looks fine. I'm pulling it into my queue and testing it. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web