Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1254635
| From | Eric Auger <eric.auger@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 6/7] vfio: platform: use list of registered reset function |
| Date | 2015-10-23 16:20 +0200 |
| Message-ID | <qmLmi-3Q4-9@gated-at.bofh.it> (permalink) |
| References | <qmJNw-1va-13@gated-at.bofh.it> <qmJNy-1va-53@gated-at.bofh.it> <qmKqf-2uc-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Arnd, On 10/23/2015 03:12 PM, Arnd Bergmann wrote: > On Friday 23 October 2015 14:37:14 Eric Auger wrote: >> Remove the static lookup table and use the dynamic list of registered >> reset functions instead. Also load the reset module through its alias. >> The reset struct module pointer is stored in vfio_platform_device. >> >> We also remove the useless struct device pointer parameter in >> vfio_platform_get_reset. >> >> This patch fixes the issue related to the usage of __symbol_get, which >> besides from being moot, prevented compilation with CONFIG_MODULES >> disabled. >> >> Also usage of MODULE_ALIAS makes possible to add a new reset module >> without needing to update the framework. This was suggested by Arnd. >> >> Signed-off-by: Eric Auger <eric.auger@linaro.org> >> Reported-by: Arnd Bergmann <arnd@arndb.de> >> >> > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > but doesn't this need to come before patch 4/7? Well I don't think so. In [4] we introduce the dynamic registration method but until this patch we still use the old lookup method in the static table. I tested and the reset lookup still works in [4]. If we put this one before the registration, the functionality will be lost here. Eric > Arnd > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 6/7] vfio: platform: use list of registered reset function Eric Auger <eric.auger@linaro.org> - 2015-10-23 14:40 +0200
Re: [PATCH v3 6/7] vfio: platform: use list of registered reset function Arnd Bergmann <arnd@arndb.de> - 2015-10-23 15:20 +0200
Re: [PATCH v3 6/7] vfio: platform: use list of registered reset function Eric Auger <eric.auger@linaro.org> - 2015-10-23 16:20 +0200
Re: [PATCH v3 6/7] vfio: platform: use list of registered reset function Arnd Bergmann <arnd@arndb.de> - 2015-10-23 16:30 +0200
Re: [PATCH v3 6/7] vfio: platform: use list of registered reset function Eric Auger <eric.auger@linaro.org> - 2015-10-23 17:20 +0200
csiph-web