Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1254634

Re: [PATCH v3 3/7] vfio: platform: introduce module_vfio_reset_handler macro

Show all headers | View raw

Hi Arnd,
On 10/23/2015 03:09 PM, Arnd Bergmann wrote:
> On Friday 23 October 2015 14:37:11 Eric Auger wrote:
>> +static int __init reset ## _module_init(void)                  \
>> +{                                                              \
>> +       vfio_platform_register_reset(compat, reset);            \
>> +       return 0;                                               \
>> +};                                                             \
>>
> 
> I would make this 'return vfio_platform_register_reset(...)', so loading
> the driver fails if the handler cannot get registered. Alternatively,
> change the return type of vfio_platform_register_reset to 'void'
> so it can never fail.
I will turn __vfio_platform_register_reset to 'void' then since it has
no reason to fail now.

Thanks

Eric

> 
> 	Arnd
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 3/7] vfio: platform: introduce module_vfio_reset_handler macro Eric Auger <eric.auger@linaro.org> - 2015-10-23 14:40 +0200
  Re: [PATCH v3 3/7] vfio: platform: introduce module_vfio_reset_handler macro Arnd Bergmann <arnd@arndb.de> - 2015-10-23 15:10 +0200
    Re: [PATCH v3 3/7] vfio: platform: introduce  module_vfio_reset_handler macro Eric Auger <eric.auger@linaro.org> - 2015-10-23 16:20 +0200

csiph-web