Re: [PATCH 11/20] sound, skylake: switch from ioremap_cache to memremap

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 11/20] sound, skylake: switch from ioremap_cache to memremap
Date	2015-10-19 18:10 +0200
Message-ID	<qllay-Yc-17@gated-at.bofh.it> (permalink)
References	<qhOkN-73l-3@gated-at.bofh.it> <qhOkP-73l-59@gated-at.bofh.it> <qlkxR-8qb-53@gated-at.bofh.it> <qlkHv-9O-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Oct 19, 2015 at 05:34:48PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > On Fri, Oct 09, 2015 at 06:16:36PM -0400, Dan Williams wrote:
> > > In preparation for deprecating ioremap_cache() convert its usage in
> > > skl-nhlt to memremap.

> > > -void __iomem *skl_nhlt_init(struct device *dev)
> > > +void *skl_nhlt_init(struct device *dev)

> > Why are we loosing the annotation here?

> It's the exact purpose of this patchset, as far as I understand.
> memremap() allows the driver accessing the mapped memory just like a
> normal memory unlike ioremap().

There's no mention of what the purpose of the conversion is in either
the patch or the cover letter so it's a bit unclear, some confirmation
would be good :(

Thread

Re: [PATCH 11/20] sound, skylake: switch from ioremap_cache to  memremap Mark Brown <broonie@kernel.org> - 2015-10-19 17:30 +0200
  Re: [PATCH 11/20] sound, skylake: switch from ioremap_cache to memremap Takashi Iwai <tiwai@suse.de> - 2015-10-19 17:40 +0200
    Re: [PATCH 11/20] sound, skylake: switch from ioremap_cache to  memremap Mark Brown <broonie@kernel.org> - 2015-10-19 18:10 +0200
      Re: [PATCH 11/20] sound, skylake: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-19 19:00 +0200

csiph-web