Re: [PATCH 11/20] sound, skylake: switch from ioremap_cache to memremap

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 11/20] sound, skylake: switch from ioremap_cache to memremap
Date	2015-10-19 19:00 +0200
Message-ID	<qllWW-1T1-29@gated-at.bofh.it> (permalink)
References	<qhOkN-73l-3@gated-at.bofh.it> <qhOkP-73l-59@gated-at.bofh.it> <qlkxR-8qb-53@gated-at.bofh.it> <qlkHv-9O-15@gated-at.bofh.it> <qllay-Yc-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 19, 2015 at 9:08 AM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, Oct 19, 2015 at 05:34:48PM +0200, Takashi Iwai wrote:
>> Mark Brown wrote:
>
>> > On Fri, Oct 09, 2015 at 06:16:36PM -0400, Dan Williams wrote:
>> > > In preparation for deprecating ioremap_cache() convert its usage in
>> > > skl-nhlt to memremap.
>
>> > > -void __iomem *skl_nhlt_init(struct device *dev)
>> > > +void *skl_nhlt_init(struct device *dev)
>
>> > Why are we loosing the annotation here?
>
>> It's the exact purpose of this patchset, as far as I understand.
>> memremap() allows the driver accessing the mapped memory just like a
>> normal memory unlike ioremap().
>
> There's no mention of what the purpose of the conversion is in either
> the patch or the cover letter so it's a bit unclear, some confirmation
> would be good :(

The cover letter linked this article which talked through the
motivation: https://lwn.net/Articles/653585/

Essentially an "__iomem" annotation on a cached mapping is
inconsistent as __iomem indicates "may have side effects, use special
accessors" and cached means "pre-fetching, asynchronous write-backs,
and cpu determined i/o sizes are permissible".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 11/20] sound, skylake: switch from ioremap_cache to  memremap Mark Brown <broonie@kernel.org> - 2015-10-19 17:30 +0200
  Re: [PATCH 11/20] sound, skylake: switch from ioremap_cache to memremap Takashi Iwai <tiwai@suse.de> - 2015-10-19 17:40 +0200
    Re: [PATCH 11/20] sound, skylake: switch from ioremap_cache to  memremap Mark Brown <broonie@kernel.org> - 2015-10-19 18:10 +0200
      Re: [PATCH 11/20] sound, skylake: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-19 19:00 +0200

csiph-web