Re: [PATCH 1/2] NFC: delete null dereference

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] NFC: delete null dereference
Date	2015-10-19 15:00 +0200
Message-ID	<qlicG-4P7-13@gated-at.bofh.it> (permalink)
References	<qkwhI-1Ly-21@gated-at.bofh.it> <qkwhJ-1Ly-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The next goto after that is messed up as well:

  1056          dev = nfc_get_device(idx);
  1057          if (!dev)
  1058                  return -ENODEV;
  1059  
  1060          device_lock(&dev->dev);
  1061  
  1062          local = nfc_llcp_find_local(dev);
  1063          if (!local) {
  1064                  nfc_put_device(dev);

It should not call nfc_put_device() because that happens after goto
exit.

  1065                  rc = -ENODEV;
  1066                  goto exit;
  1067          }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] NFC: delete null dereference Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-19 15:00 +0200

csiph-web