Re: [Y2038] [PATCH] hp_sdc: fixed y2038 problem

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [Y2038] [PATCH] hp_sdc: fixed y2038 problem
Date	Mon, 19 Oct 2015 11:10:01 +0200
Message-ID	<qleC5-8fX-3@gated-at.bofh.it> (permalink)
References	<qkSLg-1nk-5@gated-at.bofh.it>
X-Original-To	y2038@lists.linaro.org
User-Agent	KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
X-Provags-ID	V03:K0:vRrSXAerxWpHYAukgLubIpDbQyTSaNMzmP3xAxODvyu1kADgqfZ ZBWSed/aVT1fTrJ5xeBcbJiKnjpYLT/ZZYoiob6l1JYy7G/2HP6OQTmielQFaV0DSL+xoTV 678Fe7fIYF7evCOAkNTdWtr4us4su0/CKZrftV+upmzRwS7pLzgGicckza29H0jwLAr1kcu +WRHIfzQ9gspl6HjBDg6A==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:RSE6T+1m34Q=:L21Y0VjVZ3m/mMaQyn6CHk Su7ACfb5ohEObRjBeo9HdiBKeZDxCPldCo1jkuZite+xk9r3FVEo1NYKYwMibOnb56OXkzQwn C/uz5zITwxl1zxULzKlKsr30P8ItLMw64yucQhF1AMKybZ5RwyJdor4T2PcObZCvu7CufnXG/ HzU/0S4HQaMRzG2VZIqC0YIcJveoYiFt9WSCYUQF8Vq8igwwbLs2R5jyuWvp5FF14bwAJB7DZ vFaQXeExROi2UUIwdZgVKa8qoAVhapEFkLaI/hrE3V2YxFxbsjIWjR1p/AQEzd1WY132i+y+g IgQ64csXpdW50kRQChBhQhx9MiGcGhf6RgHPCbbfewqFBRJtPBgWC0ElhOuEdDslBLr194dhv xG1OkWrYjb4QjBINVj//DCIj4QXVZKbcbnlkNDaBRTWvWj2n/nKXEO3NG+zA2jFRIj+HgOWG3 7bWvmtywajQFSaCQOe3MQuvO/7mPmoVszrKQ6Vo0/UgDO+J/+hAiTytIrKtf0Am7KyCUgEO17 L60VX7JsBtSNYFiMCSX8NkUgKZ9rTlDNGcOfs+R9ny/aXYvHHs91lKDnfX6SUImXF5mHd3EMC iQrQPFL8X08FeFHCuc+utyyhbGbS/wE3eMUUKQ3yix+LkWzgiJo4mH18e20RGWw5uysWypXCY byjdF5gCvpHglNf/GX1AabCAO4Qo7N6VbWbhxX231OVxB3Ki36F6Sx2R61cCTLwkkasdHk9vQ NZL4QMkGwkn2gO/m
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	17
Organization	linux.* mail to news gateway
X-Original-Cc	WEN Pingbo <pingbo.wen@linaro.org>, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
X-Original-Date	Mon, 19 Oct 2015 11:01:50 +0200
X-Original-Message-ID	<5041745.xAgMz1TQSE@wuerfel>
X-Original-References	<1445161459-26918-1-git-send-email-pingbo.wen@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1250483

Show key headers only | View raw

On Sunday 18 October 2015 17:44:19 WEN Pingbo wrote:
> Two replacements happened in this patch:
>     1. using timespec64 to prevent time overflow in 2038
>     2. using ktime_get_ts64 to avoid wall time issues(leap second, etc)
> 
> Signed-off-by: WEN Pingbo <pingbo.wen@linaro.org>
> 

The patch looks correct, but I think this could be written a little
simpler and clearer using ktime_get() or ktime_getns().

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] hp_sdc: fixed y2038 problem WEN Pingbo <pingbo.wen@linaro.org> - 2015-10-18 11:50 +0200
  Re: [Y2038] [PATCH] hp_sdc: fixed y2038 problem Arnd Bergmann <arnd@arndb.de> - 2015-10-19 11:10 +0200
    Re: [Y2038] [PATCH] hp_sdc: fixed y2038 problem Pingbo Wen <pingbo.wen@linaro.org> - 2015-10-21 11:00 +0200
    [PATCH V2] hp_sdc: fixed y2038 problem WEN Pingbo <pingbo.wen@linaro.org> - 2015-10-23 11:00 +0200
      Re: [Y2038] [PATCH V2] hp_sdc: fixed y2038 problem Arnd Bergmann <arnd@arndb.de> - 2015-10-23 11:30 +0200
        Re: [Y2038] [PATCH V2] hp_sdc: fixed y2038 problem Pingbo Wen <pingbo.wen@linaro.org> - 2015-10-23 11:40 +0200
        [PATCH V3] hp_sdc: convert struct timeval to ktime_t WEN Pingbo <pingbo.wen@linaro.org> - 2015-10-23 13:40 +0200
          Re: [PATCH V3] hp_sdc: convert struct timeval to ktime_t Arnd Bergmann <arnd@arndb.de> - 2015-10-23 13:50 +0200
            Re: [PATCH V3] hp_sdc: convert struct timeval to ktime_t Pingbo Wen <pingbo.wen@linaro.org> - 2015-10-23 14:20 +0200
              Re: [PATCH V3] hp_sdc: convert struct timeval to ktime_t Arnd Bergmann <arnd@arndb.de> - 2015-10-23 14:40 +0200
                [PATCH V4] hp_sdc: convert struct timeval to ktime_t WEN Pingbo <pingbo.wen@linaro.org> - 2015-10-24 06:10 +0200

csiph-web