Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1254530

Re: [PATCH V3] hp_sdc: convert struct timeval to ktime_t

Show all headers | View raw

> 在 2015年10月23日，19:45，Arnd Bergmann <arnd@arndb.de> 写道：
> 
> On Friday 23 October 2015 19:29:39 WEN Pingbo wrote:
>> 1. struct timeval is not y2038 safe, convert it to ktime_t, and there is no need to handle sec and usec separately
>> 
>> 
> 
> The patch looks good now, but the changelog still needs a tiny bit of
> work. First of all, your line wrapping is off, please start a new line
> after around 70 characters as you do in an email.
> 

Well, little fault:)
Will be fixed in next version.

> Also, we don't normally have enumerated lists in a changelog, just use
> normal text. The best changelogs typically have three paragraphs:
> 
> The first paragraph describes what the driver currently does. For really
> obvious cases, this can be combined with the second paragraph.
> 
> The second paragraph explains why that is bad. This is where you can
> mention the monotonic time vs real time issue and say whether we
> just want the timeval removed to fix the kernel in general or whether
> this particular driver is broken.
> 
> The third paragraph explains what the patch does to resolve the issue
> described in the second one. This is also where you can list other
> approaches that would have solved the problem, and why you picked on
> over the others.

Do we really need this in ChangeLog? Commit msg already states this. I think
the purpose of ChangeLog is let people know the main difference of two
version patch at a glance, and the ‘what’ and ‘why’ should be placed in
commit msg.

Pingbo--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] hp_sdc: fixed y2038 problem WEN Pingbo <pingbo.wen@linaro.org> - 2015-10-18 11:50 +0200
  Re: [Y2038] [PATCH] hp_sdc: fixed y2038 problem Arnd Bergmann <arnd@arndb.de> - 2015-10-19 11:10 +0200
    Re: [Y2038] [PATCH] hp_sdc: fixed y2038 problem Pingbo Wen <pingbo.wen@linaro.org> - 2015-10-21 11:00 +0200
    [PATCH V2] hp_sdc: fixed y2038 problem WEN Pingbo <pingbo.wen@linaro.org> - 2015-10-23 11:00 +0200
      Re: [Y2038] [PATCH V2] hp_sdc: fixed y2038 problem Arnd Bergmann <arnd@arndb.de> - 2015-10-23 11:30 +0200
        Re: [Y2038] [PATCH V2] hp_sdc: fixed y2038 problem Pingbo Wen <pingbo.wen@linaro.org> - 2015-10-23 11:40 +0200
        [PATCH V3] hp_sdc: convert struct timeval to ktime_t WEN Pingbo <pingbo.wen@linaro.org> - 2015-10-23 13:40 +0200
          Re: [PATCH V3] hp_sdc: convert struct timeval to ktime_t Arnd Bergmann <arnd@arndb.de> - 2015-10-23 13:50 +0200
            Re: [PATCH V3] hp_sdc: convert struct timeval to ktime_t Pingbo Wen <pingbo.wen@linaro.org> - 2015-10-23 14:20 +0200
              Re: [PATCH V3] hp_sdc: convert struct timeval to ktime_t Arnd Bergmann <arnd@arndb.de> - 2015-10-23 14:40 +0200
                [PATCH V4] hp_sdc: convert struct timeval to ktime_t WEN Pingbo <pingbo.wen@linaro.org> - 2015-10-24 06:10 +0200

csiph-web