Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1250390

Re: [PATCH] libata: add support for NCQ commands for SG interface

Show all headers | View raw

On Sun, Oct 18, 2015 at 12:12 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 10/17/2015 3:25 PM, Vinayak Kale wrote:
>
>>>> From: Vinayak Kale <vinayak.kale@seagate.com>
>>>>
>>>> This patch is needed to make NCQ commands with FPDMA protocol value
>>>> (eg READ/WRITE FPDMA) work over SCSI Generic (SG) interface.
>>>>
>>>> Signed-off-by: Vinayak Kale <vinayak.kale@seagate.com>
>>>> ---
>>>>    drivers/ata/libata-scsi.c | 10 ++++++++--
>>>>    1 file changed, 8 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
>>>> index 0d7f0da..5b0a5ab 100644
>>>> --- a/drivers/ata/libata-scsi.c
>>>> +++ b/drivers/ata/libata-scsi.c
>>>
>>>
>>> [...]
>>>>
>>>>
>>>> @@ -2963,7 +2965,7 @@ static unsigned int ata_scsi_pass_thru(struct
>>>> ata_queued_cmd *qc)
>>>>                          tf->hob_lbal = cdb[7];
>>>>                          tf->hob_lbam = cdb[9];
>>>>                          tf->hob_lbah = cdb[11];
>>>> -                       tf->flags |= ATA_TFLAG_LBA48;
>>>> +                       tf->flags |= (ATA_TFLAG_LBA48 | ATA_TFLAG_LBA);
>>>
>>>
>>>
>>>     Parens not needed here.
>>
>> That's quite neat :-) Thanks, will change it in V2.
>
>
>     Looking at this hunk again, it seems an unrelated change.

I added ATA_TFLAG_LBA to tf->flags just to conform with similar piece
of code in libata-core.c.
FPDMA Read/Write commands run smoothly even without this flag.
I wouldn't mind removing this change from current patch if it's deemed
unfit here.

>
> MBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] libata: add support for NCQ commands for SG interface vinayak.kale@gmail.com - 2015-10-17 13:50 +0200
  Re: [PATCH] libata: add support for NCQ commands for SG interface Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-10-17 14:10 +0200
    Re: [PATCH] libata: add support for NCQ commands for SG interface Vinayak Kale <vinayak.kale@gmail.com> - 2015-10-17 14:30 +0200
      Re: [PATCH] libata: add support for NCQ commands for SG interface Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-10-17 20:50 +0200
        Re: [PATCH] libata: add support for NCQ commands for SG interface Vinayak Kale <vinayak.kale@gmail.com> - 2015-10-19 09:00 +0200
  Re: [PATCH] libata: add support for NCQ commands for SG interface Vinayak Kale <vinayak.kale@gmail.com> - 2015-10-21 07:20 +0200
    Re: [PATCH] libata: add support for NCQ commands for SG interface Tejun Heo <tj@kernel.org> - 2015-10-22 11:00 +0200
      Re: [PATCH] libata: add support for NCQ commands for SG interface Tejun Heo <tj@kernel.org> - 2015-10-23 07:50 +0200
        Re: [PATCH] libata: add support for NCQ commands for SG interface Vinayak Kale <vinayak.kale@seagate.com> - 2015-10-23 22:10 +0200

csiph-web