Re: [PATCH] libata: add support for NCQ commands for SG interface

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] libata: add support for NCQ commands for SG interface
Date	2015-10-23 07:50 +0200
Message-ID	<qmDoK-AJ-5@gated-at.bofh.it> (permalink)
References	<qky9P-4G1-1@gated-at.bofh.it> <qlTYC-1xg-3@gated-at.bofh.it> <qmjT4-5Ic-15@gated-at.bofh.it> <qmDoK-AJ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Fri, Oct 23, 2015 at 10:01:35AM +0530, Vinayak Kale wrote:
> > It looks like it'd work given that it's forcing qc->tag into
> > tf->nsect.  What's the use case tho?
> 
> We need to issue NCQ commands with priority bit from user space application.
> 
> BTW, Sergei Shtylyov raised concern regarding usefulness of adding
> ATA_TFLAG_LBA to tf->flags. Can you please comment on that as well?
> Accordingly I will either keep it or discard it in V2. Thanks.

I like the change but can you please put that in a separate patch?
Also, can you please verify that this works fine with multiple regular
NCQ commands in flight?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] libata: add support for NCQ commands for SG interface Vinayak Kale <vinayak.kale@gmail.com> - 2015-10-21 07:20 +0200
  Re: [PATCH] libata: add support for NCQ commands for SG interface Tejun Heo <tj@kernel.org> - 2015-10-22 11:00 +0200
    Re: [PATCH] libata: add support for NCQ commands for SG interface Tejun Heo <tj@kernel.org> - 2015-10-23 07:50 +0200
      Re: [PATCH] libata: add support for NCQ commands for SG interface Vinayak Kale <vinayak.kale@seagate.com> - 2015-10-23 22:10 +0200

csiph-web