[PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

From	David Herrmann <dh.herrmann@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces
Date	2015-10-21 12:50 +0200
Message-ID	<qlZ7X-tR-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The thinkpad_acpi driver currently emits error messages on unsupported
brightness interfaces, giving the impression that someone will implement
those. However, this error is spit out on nearly every thinkpad in
production since 2 years now. Furthermore, the backlight interfaces on
those devices are supported by the i915 driver just fine.

Downgrade the error message to a normal pr_info() and stop telling people
to report it to IBM.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
---
 drivers/platform/x86/thinkpad_acpi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 131dd74..0bed473 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6459,8 +6459,7 @@ static void __init tpacpi_detect_brightness_capabilities(void)
 		pr_info("detected a 8-level brightness capable ThinkPad\n");
 		break;
 	default:
-		pr_err("Unsupported brightness interface, "
-		       "please contact %s\n", TPACPI_MAIL);
+		pr_info("Unsupported brightness interface\n");
 		tp_features.bright_unkfw = 1;
 		bright_maxlvl = b - 1;
 	}
-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces David Herrmann <dh.herrmann@gmail.com> - 2015-10-21 12:50 +0200
  Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness  interfaces Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2015-10-21 16:40 +0200
    Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness  interfaces Darren Hart <dvhart@infradead.org> - 2015-10-21 16:50 +0200

csiph-web