Re: [RFC PATCH] qspinlock: Improve performance by reducing load instruction rollback

From	Ling Ma <ling.ma.program@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] qspinlock: Improve performance by reducing load instruction rollback
Date	2015-10-21 07:50 +0200
Message-ID	<qlUrE-253-5@gated-at.bofh.it> (permalink)
References	<ql8n0-7wA-19@gated-at.bofh.it> <qlmgi-2vV-9@gated-at.bofh.it> <qlvCV-816-7@gated-at.bofh.it> <qlKiC-3V5-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>
> I did see some performance improvement when I used your test program on a
> Haswell-EX system. It seems like the use of cmpxchg has forced the changed
> memory values to be visible to other processors earlier. I also ran your
> test on an older machine with Westmere-EX processors. This time, I didn't
> see any performance improvement. In fact, your change actually make it a
> tiny bit slower. So the benefit of your patch can be highly processor
> sensitive.
>
> As other architectures like ARM & AA64 are going to adopt qspinlock in the
> near future, we will also need to make sure that it won't cause a regression
> there. So I don't see your patch has a big chance of being merged upstream
> unless you can provide a real world workload that can benefit from your
> patch. Even then, proving that it won't cause regression in other processors
> or architectures can be tedious.
>

The optimization will be closely related with CPU arch and cache
coherence implementation.
so we will test it for real world workload on Haswell, and send out the result.

Thanks
Ling
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH] qspinlock: Improve performance by reducing load instruction rollback ling.ma.program@gmail.com - 2015-10-19 04:30 +0200
  Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Ingo Molnar <mingo@kernel.org> - 2015-10-19 10:00 +0200
    Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Peter Zijlstra <peterz@infradead.org> - 2015-10-19 11:40 +0200
      Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Ingo Molnar <mingo@kernel.org> - 2015-10-19 13:30 +0200
        Re: [RFC PATCH] qspinlock: Improve performance by reducing load instruction  rollback Waiman Long <waiman.long@hpe.com> - 2015-10-19 19:30 +0200
    Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Ling Ma <ling.ma.program@gmail.com> - 2015-10-20 05:00 +0200
      Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Ingo Molnar <mingo@kernel.org> - 2015-10-20 10:50 +0200
        Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Ling Ma <ling.ma.program@gmail.com> - 2015-10-21 07:30 +0200
      Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Peter Zijlstra <peterz@infradead.org> - 2015-10-20 11:20 +0200
  Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Peter Zijlstra <peterz@infradead.org> - 2015-10-19 11:40 +0200
    Re: [RFC PATCH] qspinlock: Improve performance by reducing load instruction  rollback Waiman Long <waiman.long@hpe.com> - 2015-10-19 19:30 +0200
    Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Ling Ma <ling.ma.program@gmail.com> - 2015-10-20 05:10 +0200
  Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Peter Zijlstra <peterz@infradead.org> - 2015-10-19 11:50 +0200
    Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Ling Ma <ling.ma.program@gmail.com> - 2015-10-20 05:10 +0200
    Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Ling Ma <ling.ma.program@gmail.com> - 2015-10-20 05:30 +0200
      Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Peter Zijlstra <peterz@infradead.org> - 2015-10-20 11:20 +0200
        Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Ling Ma <ling.ma.program@gmail.com> - 2015-10-21 07:40 +0200
  Re: [RFC PATCH] qspinlock: Improve performance by reducing load instruction  rollback Waiman Long <waiman.long@hpe.com> - 2015-10-19 19:20 +0200
    Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Ling Ma <ling.ma.program@gmail.com> - 2015-10-20 05:20 +0200
      Re: [RFC PATCH] qspinlock: Improve performance by reducing load instruction  rollback Waiman Long <waiman.long@hpe.com> - 2015-10-20 21:00 +0200
        Re: [RFC PATCH] qspinlock: Improve performance by reducing load  instruction rollback Ling Ma <ling.ma.program@gmail.com> - 2015-10-21 07:50 +0200

csiph-web