Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1251921

Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free

Show all headers | View raw

2015-08-21 7:29 GMT+03:00 Dāvis Mosāns <davispuh@gmail.com>:
> When pci_pool_alloc fails in mvs_task_prep then task->lldd_task stays
> NULL but it's later used in mvs_abort_task as slot which is passed
> to mvs_slot_task_free causing NULL pointer dereference.
>
> Just return from mvs_slot_task_free when passed with NULL slot.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=101891
> Signed-off-by: Dāvis Mosāns <davispuh@gmail.com>
> ---
>  drivers/scsi/mvsas/mv_sas.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
> index 454536c..9c78074 100644
> --- a/drivers/scsi/mvsas/mv_sas.c
> +++ b/drivers/scsi/mvsas/mv_sas.c
> @@ -887,6 +887,8 @@ static void mvs_slot_free(struct mvs_info *mvi, u32 rx_desc)
>  static void mvs_slot_task_free(struct mvs_info *mvi, struct sas_task *task,
>                           struct mvs_slot_info *slot, u32 slot_idx)
>  {
> +       if (!slot)
> +               return;
>         if (!slot->task)
>                 return;
>         if (!sas_protocol_ata(task->task_proto))
> --
> 2.5.0
>

Can this get merged?
So far since august it have saved me from several kernel crashes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free Dāvis Mosāns <davispuh@gmail.com> - 2015-10-20 19:50 +0200
  Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in  mvs_slot_task_free Johannes Thumshirn <jthumshirn@suse.de> - 2015-10-21 09:40 +0200
    Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free Dāvis Mosāns <davispuh@gmail.com> - 2015-10-21 15:20 +0200
      Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in  mvs_slot_task_free Johannes Thumshirn <jthumshirn@suse.de> - 2015-10-21 15:50 +0200
        Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in  mvs_slot_task_free Johannes Thumshirn <jthumshirn@suse.de> - 2015-10-21 16:30 +0200
        Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free Dāvis Mosāns <davispuh@gmail.com> - 2015-10-21 16:30 +0200

csiph-web