Groups > linux.kernel > #1251920

Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC
Date	2015-10-20 19:50 +0200
Message-ID	<qlJcS-2mJ-17@gated-at.bofh.it> (permalink)
References	(1 earlier) <qlpHc-7uj-19@gated-at.bofh.it> <qlIqu-1ak-21@gated-at.bofh.it> <qlIqu-1ak-19@gated-at.bofh.it> <qlITw-1Zy-19@gated-at.bofh.it> <qlJ3c-2aM-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Oct 20, 2015 at 07:36:39PM +0200, Borislav Petkov wrote:
> On Tue, Oct 20, 2015 at 06:26:55PM +0100, Mark Rutland wrote:
> > > Btw, how much of this is implementing generic A57 functionality?
> > 
> > The driver is entirely A57 generic.
> > 
> > > If a lot, can we make this a generic a57_edac driver so that multiple
> > > vendors can use it?
> > 
> > Yes.
> 
> Ok, cool.
> 
> > > How fast and how ugly can something like that become?
> > 
> > Not sure I follow.
> 
> In the sense that some vendor might require just a little bit different
> handling or maybe wants to read some vendor-specific registers in
> addition to the architectural ones.
> 
> Then we'll start adding vendor-specific hacks to that generic driver.
> And therefore the question how fast and how ugly such hacks would
> become.
> 
> I guess we'll worry about that when we get there...
> 
> So Brijesh, if you only need generic, architectural functionality,
> please call it arm64_edac or so and let's add it so that other arm64
> vendors can use it too.

Please note that this is specific to Cortex-A57, not ARMv8 or aarch64.

It is an IMPLEMENTATION DEFINED feature as implemented by Cortex-A57,
which by definition is not implemented by other CPUs. It is not provided
by the ARM architecture.

So this cannot be arm64_edac, but could potentially be cortex_a57_edac.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC Mark Rutland <mark.rutland@arm.com> - 2015-10-19 23:00 +0200
  Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC Borislav Petkov <bp@alien8.de> - 2015-10-20 19:00 +0200
    Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC Mark Rutland <mark.rutland@arm.com> - 2015-10-20 19:30 +0200
      Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC Borislav Petkov <bp@alien8.de> - 2015-10-20 19:40 +0200
        Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC Mark Rutland <mark.rutland@arm.com> - 2015-10-20 19:50 +0200
        Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC Hanjun Guo <guohanjun@huawei.com> - 2015-10-21 04:00 +0200
          Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC Borislav Petkov <bp@alien8.de> - 2015-10-21 11:40 +0200
            Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC Andre Przywara <andre.przywara@arm.com> - 2015-10-21 12:10 +0200
            Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC Hanjun Guo <guohanjun@huawei.com> - 2015-10-23 03:50 +0200
  Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC Mark Rutland <mark.rutland@arm.com> - 2015-10-20 19:30 +0200
    Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC Hanjun Guo <guohanjun@huawei.com> - 2015-10-21 03:50 +0200

csiph-web