Re: [PATCH] serial: sh-sci: Fix length of scatterlist

Path	csiph.com!goblin3!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] serial: sh-sci: Fix length of scatterlist
Date	Tue, 20 Oct 2015 14:30:02 +0200
Message-ID	<qlEdc-3CF-19@gated-at.bofh.it> (permalink)
References	<qlE3v-3rm-3@gated-at.bofh.it>
X-Original-To	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=FOw9k0humLu6Jh65fyLtDfLk+iuC2BjA7DkMjVdhHQE=; b=EWoPA3Q32hEIlzgFwc1e3opPMwC2dDJ7UrdGfENjh8DwsA0rgBFArWY1uoCyIPj93I Vj3WMU/Ov1QehgNLFGgYmuMlI+Zr3Ns3reXAQHThbkAtpNPGUn+9XL3WOwzN0c2vRijh Sg6PMZBPJFijVhNdFIjePLlSo+bctDxxVQSEHz4IEQP9nnNki4tuuMd3o1nGS3tvDXL7 HogXFsFOKt203h5IKtqV6F50KFK7Vu3dXu8Jd+m7e//0U+2Mpyp2i7TevrIN4JR+LMXr bF+8Zr5eGOmFd4RXaF9k3engy7vdCp2ZRh9D+AK+SY0TgJ0a6inoxdjraiAohk+Hw+6z N8iw==
MIME-Version	1.0
X-Received	by 10.60.179.196 with SMTP id di4mr1715698oec.53.1445343743065; Tue, 20 Oct 2015 05:22:23 -0700 (PDT)
X-Google-Sender-Auth	tSCaS-N2hoj_AOOUJBoaoXNQPMo
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	Greg KH <gregkh@linuxfoundation.org>, jslaby@suse.com, "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Linux-sh list <linux-sh@vger.kernel.org>
X-Original-Date	Tue, 20 Oct 2015 14:22:23 +0200
X-Original-Message-ID	<CAMuHMdVNeSMnFqRxxqmP+v8PBVnzoh3sdyMyqt_3=USoL=09Vw@mail.gmail.com>
X-Original-References	<1445343502-4436-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1251637

Show key headers only | View raw

Hi Shimoda-san,

On Tue, Oct 20, 2015 at 2:18 PM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> This patch fixes an issue that the "length" of scatterlist should be
> set using sh_dma_length(). Otherwise, a dmaengine driver cannot work

sg_dma_len()?

> correctly if CONFIG_NEED_SG_DMA_LENGTH=y.
>
> Fixes: 7b39d90184 (serial: sh-sci: Fix NULL pointer dereference if HIGHMEM is enabled)
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>  drivers/tty/serial/sh-sci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 960e50a..284a872 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -1437,7 +1437,7 @@ static void sci_request_dma(struct uart_port *port)
>                         sg_init_table(sg, 1);
>                         s->rx_buf[i] = buf;
>                         sg_dma_address(sg) = dma;
> -                       sg->length = s->buf_len_rx;
> +                       sg_dma_length(sg) = s->buf_len_rx;

There's no definition for "sg_dma_length" in my tree?? sg_dma_len()?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] serial: sh-sci: Fix length of scatterlist Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2015-10-20 14:20 +0200
  Re: [PATCH] serial: sh-sci: Fix length of scatterlist Geert Uytterhoeven <geert@linux-m68k.org> - 2015-10-20 14:30 +0200
    RE: [PATCH] serial: sh-sci: Fix length of scatterlist Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2015-10-22 08:40 +0200

csiph-web