Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1251637

Re: [PATCH] serial: sh-sci: Fix length of scatterlist

Show all headers | View raw

Hi Shimoda-san,

On Tue, Oct 20, 2015 at 2:18 PM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> This patch fixes an issue that the "length" of scatterlist should be
> set using sh_dma_length(). Otherwise, a dmaengine driver cannot work

sg_dma_len()?

> correctly if CONFIG_NEED_SG_DMA_LENGTH=y.
>
> Fixes: 7b39d90184 (serial: sh-sci: Fix NULL pointer dereference if HIGHMEM is enabled)
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>  drivers/tty/serial/sh-sci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 960e50a..284a872 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -1437,7 +1437,7 @@ static void sci_request_dma(struct uart_port *port)
>                         sg_init_table(sg, 1);
>                         s->rx_buf[i] = buf;
>                         sg_dma_address(sg) = dma;
> -                       sg->length = s->buf_len_rx;
> +                       sg_dma_length(sg) = s->buf_len_rx;

There's no definition for "sg_dma_length" in my tree?? sg_dma_len()?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] serial: sh-sci: Fix length of scatterlist Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2015-10-20 14:20 +0200
  Re: [PATCH] serial: sh-sci: Fix length of scatterlist Geert Uytterhoeven <geert@linux-m68k.org> - 2015-10-20 14:30 +0200
    RE: [PATCH] serial: sh-sci: Fix length of scatterlist Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2015-10-22 08:40 +0200

csiph-web