Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1250306

Re: [PATCH] net: hisilicon: add OF dependency

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 16 Oct 2015 11:33:49 +0200

> The HNS MDIO driver fails to build on older ARM machines that are not
> yet converted to CONFIG_OF:
> 
> drivers/net/ethernet/hisilicon/hns_mdio.c: In function 'hns_mdio_bus_name':
> drivers/net/ethernet/hisilicon/hns_mdio.c:405:14: error: 'OF_BAD_ADDR' undeclared (first use in this function)
>   u64 taddr = OF_BAD_ADDR;
>               ^
> drivers/net/ethernet/hisilicon/hns_mdio.c:405:14: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/ethernet/hisilicon/hns_mdio.c:409:11: error: implicit declaration of function 'of_translate_address' [-Werror=implicit-function-declaration]
>    taddr = of_translate_address(np, addr);
>            ^
> 
> This clarifies the dependency to ensure we don't attempt to build these
> drivers without CONFIG_OF, but also adds a COMPILE_TEST alternative to
> give us better build coverage testing.
> 
> Build-tested on x86 as well to ensure this actually works.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS drivers huangdaode <huangdaode@hisilicon.com> - 2015-10-16 05:40 +0200
  [PATCH net-next v3 1/2] net: hisilicon rm hnae sysfs interface huangdaode <huangdaode@hisilicon.com> - 2015-10-16 05:40 +0200
    Re: [PATCH net-next v3 1/2] net: hisilicon rm hnae sysfs interface Arnd Bergmann <arnd@arndb.de> - 2015-10-16 11:30 +0200
  [PATCH] net: hisilicon: include linux/vmalloc.h in dsaf Arnd Bergmann <arnd@arndb.de> - 2015-10-16 11:40 +0200
    Re: [PATCH] net: hisilicon: include linux/vmalloc.h in dsaf David Miller <davem@davemloft.net> - 2015-10-19 04:50 +0200
  [PATCH] net: hisilicon: add OF dependency Arnd Bergmann <arnd@arndb.de> - 2015-10-16 11:40 +0200
    Re: [PATCH] net: hisilicon: add OF dependency kbuild test robot <lkp@intel.com> - 2015-10-16 19:10 +0200
    Re: [PATCH] net: hisilicon: add OF dependency kbuild test robot <lkp@intel.com> - 2015-10-16 20:20 +0200
      Re: [PATCH] net: hisilicon: add OF dependency Joe Perches <joe@perches.com> - 2015-10-16 20:30 +0200
    Re: [PATCH] net: hisilicon: add OF dependency David Miller <davem@davemloft.net> - 2015-10-19 04:50 +0200
  Re: [PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS drivers Arnd Bergmann <arnd@arndb.de> - 2015-10-16 11:40 +0200
    Re: [PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS drivers huangdaode <huangdaode@hisilicon.com> - 2015-10-19 04:30 +0200
  [PATCH] net: hix5hd2_gmac: avoid integer overload warning Arnd Bergmann <arnd@arndb.de> - 2015-10-16 12:10 +0200
    RE: [PATCH] net: hix5hd2_gmac: avoid integer overload warning David Laight <David.Laight@ACULAB.COM> - 2015-10-16 13:20 +0200
      Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning Arnd Bergmann <arnd@arndb.de> - 2015-10-16 13:30 +0200
        Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning Joe Perches <joe@perches.com> - 2015-10-16 20:10 +0200
          Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-10-16 21:00 +0200
            Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning Joe Perches <joe@perches.com> - 2015-10-16 23:30 +0200
              Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning Arnd Bergmann <arnd@arndb.de> - 2015-10-16 23:50 +0200
    Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning David Miller <davem@davemloft.net> - 2015-10-19 04:50 +0200
  Re: [PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS  drivers David Miller <davem@davemloft.net> - 2015-10-19 04:40 +0200

csiph-web