Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks
Date	2015-10-17 12:00 +0200
Message-ID	<qkwro-21I-9@gated-at.bofh.it> (permalink)
References	(3 earlier) <qkcCm-6zl-17@gated-at.bofh.it> <qkgZl-4EI-23@gated-at.bofh.it> <qkiop-6zg-9@gated-at.bofh.it> <qkmV3-4R4-1@gated-at.bofh.it> <qkvvk-AU-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Krzysztof,

On 10/17/2015 10:53 AM, Krzysztof Kozlowski wrote:
> 2015-10-17 8:41 GMT+09:00 Kukjin Kim <kgene@kernel.org>:

[snip]

>>>
>> So...how can I take 2nd patch of this series in samsung(arm-soc) tree?
>> And this series shouldn't be for fixes for 4.3?...Mike how do you think?
> 
> Stephen acked it so I thought everything will go through samsung-soc.
> 
> Dear Kukjin,
> Indeed this can go as fix for current cycle... but in the same time
> this does not fix any specific regression. Tomeu did not describe when
> issue happened for the first time so I assumed it was like that
> always. It's up to you.
>

Sorry for not answering about this series before but I've been in contact
with Tomeu over IRC before he posted it and since you already added your
Reviewed-by tag, I didn't feel the need do to it.

This is a regression for 4.3 since S2R was working correctly for 4.2 in
Snow, I tested after fixing resume with commit 6fd4899a54a5 ("irqchip:
exynos-combiner: Save IRQ enable set on suspend") and the display was
always enabled on resume.

I don't have access to a Snow anymore to bisect but I think the regression
was introduced by some of the changes in 4.3 to migrate the Exynos DRM to
Atomic Mode Settings. But probably that just exposed a latent bug and it
was working out of luck since I had the same issue than Tomeu in Exynos5420
and was fixed in the same way with commits:

885601002998 ("clk: exynos5420: Add IDs for clocks used in DISP1 power domain")
ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")

> Both patches (with Stephen's ack) are in my recent pull request but as
> usual feel free to cherry pick. I'll drop them from next branch then.
> 
> Best regards,
> Krzysztof
> --

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2 0/2] Fix display on second resume on 5250-snow Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-10-15 12:40 +0200
  [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-10-15 12:40 +0200
    Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-16 01:50 +0200
      Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks Michael Turquette <mturquette@baylibre.com> - 2015-10-16 14:50 +0200
        Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks Stephen Boyd <sboyd@codeaurora.org> - 2015-10-16 19:30 +0200
          Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-10-16 21:00 +0200
            Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks Kukjin Kim <kgene@kernel.org> - 2015-10-17 01:50 +0200
              Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-17 11:00 +0200
                Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-17 12:00 +0200
                Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-17 12:10 +0200
  [PATCH v2 2/2] ARM: dts: exynos5250: Add clocks to DISP1 domain Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-10-15 12:40 +0200
    Re: [PATCH v2 2/2] ARM: dts: exynos5250: Add clocks to DISP1 domain Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-16 01:50 +0200
      Re: [PATCH v2 2/2] ARM: dts: exynos5250: Add clocks to DISP1 domain Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-10-16 10:20 +0200

csiph-web