Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1249238

Re: [PATCH net-next] RDS: fix rds-ping deadlock over TCP transport

Show all headers | View raw

On 10/16/2015 6:45 PM, Sowmini Varadhan wrote:
> On (10/16/15 20:26), Santosh Shilimkar wrote:
>>
>> diff --git a/net/rds/send.c b/net/rds/send.c
>> +	if (!test_bit(RDS_LL_SEND_FULL, &conn->c_flags))
>> +		queue_delayed_work(rds_wq, &conn->c_send_w, 0);
>
> A minor note- it would help to add some comments here explaining
> that the pong has already been added to the sendq earlier..
> in the case of IB, if RDS_LL_SEND_FULL has been set, it takes some
> head-scratching to figure out how the pong gets sent, and a  few
> comments could help clarify that.
>
Right. The check confused you. I will update the patch and drop
the check all together and add a jiffies for the queuing which
should take care of it. Will post v2 with that update.

> but other than that, the contents look good to me, thus
>
> Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
>
Thanks !!

regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] RDS: fix rds-ping deadlock over TCP transport Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2015-10-17 02:30 +0200
  Re: [PATCH net-next] RDS: fix rds-ping deadlock over TCP transport Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-17 03:50 +0200
    Re: [PATCH net-next] RDS: fix rds-ping deadlock over TCP transport santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-10-17 04:00 +0200

csiph-web