Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1249234
| From | Sowmini Varadhan <sowmini.varadhan@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next] RDS: fix rds-ping deadlock over TCP transport |
| Date | 2015-10-17 03:50 +0200 |
| Message-ID | <qkoNb-7xp-1@gated-at.bofh.it> (permalink) |
| References | <qknxL-5Pz-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On (10/16/15 20:26), Santosh Shilimkar wrote: > > diff --git a/net/rds/send.c b/net/rds/send.c > + if (!test_bit(RDS_LL_SEND_FULL, &conn->c_flags)) > + queue_delayed_work(rds_wq, &conn->c_send_w, 0); A minor note- it would help to add some comments here explaining that the pong has already been added to the sendq earlier.. in the case of IB, if RDS_LL_SEND_FULL has been set, it takes some head-scratching to figure out how the pong gets sent, and a few comments could help clarify that. but other than that, the contents look good to me, thus Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next] RDS: fix rds-ping deadlock over TCP transport Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2015-10-17 02:30 +0200
Re: [PATCH net-next] RDS: fix rds-ping deadlock over TCP transport Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-17 03:50 +0200
Re: [PATCH net-next] RDS: fix rds-ping deadlock over TCP transport santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-10-17 04:00 +0200
csiph-web