Re: [PATCH] spi: Setup the master controller driver before setting the chipselect

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] spi: Setup the master controller driver before setting the chipselect
Date	Fri, 16 Oct 2015 16:50:02 +0200
Message-ID	<qkeuu-Sc-17@gated-at.bofh.it> (permalink)
References	<qjXN0-1dR-19@gated-at.bofh.it> <qkaqS-3p4-25@gated-at.bofh.it> <qkeb8-uX-5@gated-at.bofh.it>
X-Original-To	"Franklin S Cooper Jr." <fcooper@ti.com>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0FDNE3+7N8PCoNAN"
Content-Disposition	inline
X-Cookie	Do you like "TENDER VITTLES"?
User-Agent	Mutt/1.5.24 (2015-08-30)
X-Sa-Exim-Connect-IP	94.175.94.161
X-Sa-Exim-Mail-From	broonie@sirena.org.uk
X-Sa-Exim-Version	4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-Sa-Exim-Scanned	Yes (on mezzanine.sirena.org.uk)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, nsekhar@ti.com, ssantosh@kernel.org, iivanov@mm-sol.com, m-karicheri2@ti.com, iivanov.xz@gmail.com, andy.shevchenko@gmail.com, jarkko.nikula@linux.intel.com, hkallweit1@gmail.com
X-Original-Date	Fri, 16 Oct 2015 15:43:05 +0100
X-Original-Message-ID	<20151016144305.GO14956@sirena.org.uk>
X-Original-References	<1444942305-24038-1-git-send-email-fcooper@ti.com> <20151016102846.GJ14956@sirena.org.uk> <56210966.3040501@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1248829

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Oct 16, 2015 at 09:27:50AM -0500, Franklin S Cooper Jr. wrote:

> Makes sense. How about something like this?

> SPI controllers may need to be properly setup before chip selects
> can be used. Therefore, wait until the spi controller has a chance
> to perform their setup procedure before trying to use the chip
> select.

Yes, that's a lot better - there's also the fact that if we assert chip
select before we've got the pins in a good state we may cause the device
to see signals that confuse it as we change.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] spi: Setup the master controller driver before setting the chipselect Franklin S Cooper Jr <fcooper@ti.com> - 2015-10-15 23:00 +0200
  Re: [PATCH] spi: Setup the master controller driver before setting  the chipselect Mark Brown <broonie@kernel.org> - 2015-10-16 12:30 +0200
    Re: [PATCH] spi: Setup the master controller driver before setting  the chipselect "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-16 16:30 +0200
      Re: [PATCH] spi: Setup the master controller driver before setting  the chipselect "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-16 16:50 +0200
      Re: [PATCH] spi: Setup the master controller driver before setting  the chipselect Mark Brown <broonie@kernel.org> - 2015-10-16 16:50 +0200

csiph-web