Re: [PATCH] spi: Setup the master controller driver before setting the chipselect

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] spi: Setup the master controller driver before setting the chipselect
Date	2015-10-16 16:50 +0200
Message-ID	<qkeuu-Sc-17@gated-at.bofh.it> (permalink)
References	<qjXN0-1dR-19@gated-at.bofh.it> <qkaqS-3p4-25@gated-at.bofh.it> <qkeb8-uX-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Oct 16, 2015 at 09:27:50AM -0500, Franklin S Cooper Jr. wrote:

> Makes sense. How about something like this?

> SPI controllers may need to be properly setup before chip selects
> can be used. Therefore, wait until the spi controller has a chance
> to perform their setup procedure before trying to use the chip
> select.

Yes, that's a lot better - there's also the fact that if we assert chip
select before we've got the pins in a good state we may cause the device
to see signals that confuse it as we change.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] spi: Setup the master controller driver before setting the chipselect Franklin S Cooper Jr <fcooper@ti.com> - 2015-10-15 23:00 +0200
  Re: [PATCH] spi: Setup the master controller driver before setting  the chipselect Mark Brown <broonie@kernel.org> - 2015-10-16 12:30 +0200
    Re: [PATCH] spi: Setup the master controller driver before setting  the chipselect "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-16 16:30 +0200
      Re: [PATCH] spi: Setup the master controller driver before setting  the chipselect "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-16 16:50 +0200
      Re: [PATCH] spi: Setup the master controller driver before setting  the chipselect Mark Brown <broonie@kernel.org> - 2015-10-16 16:50 +0200

csiph-web