Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1248826
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | "Franklin S Cooper Jr." <fcooper@ti.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] spi: Setup the master controller driver before setting the chipselect |
| Date | Fri, 16 Oct 2015 16:50:02 +0200 |
| Message-ID | <qkeuu-Sc-15@gated-at.bofh.it> (permalink) |
| References | <qjXN0-1dR-19@gated-at.bofh.it> <qkaqS-3p4-25@gated-at.bofh.it> <qkeb8-uX-5@gated-at.bofh.it> <qkeuu-Sc-17@gated-at.bofh.it> |
| X-Original-To | Mark Brown <broonie@kernel.org> |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset="UTF-8" |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 21 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>, <nsekhar@ti.com>, <ssantosh@kernel.org>, <iivanov@mm-sol.com>, <m-karicheri2@ti.com>, <iivanov.xz@gmail.com>, <andy.shevchenko@gmail.com>, <jarkko.nikula@linux.intel.com>, <hkallweit1@gmail.com> |
| X-Original-Date | Fri, 16 Oct 2015 09:45:48 -0500 |
| X-Original-Message-ID | <56210D9C.6090800@ti.com> |
| X-Original-References | <1444942305-24038-1-git-send-email-fcooper@ti.com> <20151016102846.GJ14956@sirena.org.uk> <56210966.3040501@ti.com> <20151016144305.GO14956@sirena.org.uk> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1248826 |
Show key headers only | View raw
On 10/16/2015 09:43 AM, Mark Brown wrote: > On Fri, Oct 16, 2015 at 09:27:50AM -0500, Franklin S Cooper Jr. wrote: > >> Makes sense. How about something like this? >> SPI controllers may need to be properly setup before chip selects >> can be used. Therefore, wait until the spi controller has a chance >> to perform their setup procedure before trying to use the chip >> select. > Yes, that's a lot better - there's also the fact that if we assert chip > select before we've got the pins in a good state we may cause the device > to see signals that confuse it as we change. Ok. I'll submit a rev2 with my updated commit message and incorporate your suggestion also. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] spi: Setup the master controller driver before setting the chipselect Franklin S Cooper Jr <fcooper@ti.com> - 2015-10-15 23:00 +0200
Re: [PATCH] spi: Setup the master controller driver before setting the chipselect Mark Brown <broonie@kernel.org> - 2015-10-16 12:30 +0200
Re: [PATCH] spi: Setup the master controller driver before setting the chipselect "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-16 16:30 +0200
Re: [PATCH] spi: Setup the master controller driver before setting the chipselect "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-16 16:50 +0200
Re: [PATCH] spi: Setup the master controller driver before setting the chipselect Mark Brown <broonie@kernel.org> - 2015-10-16 16:50 +0200
csiph-web