Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1248793

Re: [PATCH v2] scsi: advansys needs ISA dma api for ISA support

Show all headers | View raw

On Friday 16 October 2015 06:53:44 James Bottomley wrote:
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > 
> > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> > index d2f480b04a52..1d8b8257773d 100644
> > --- a/drivers/scsi/Kconfig
> > +++ b/drivers/scsi/Kconfig
> > @@ -498,7 +498,7 @@ config SCSI_DPT_I2O
> >  config SCSI_ADVANSYS
> >       tristate "AdvanSys SCSI support"
> >       depends on SCSI
> > -     depends on ISA || EISA || PCI
> > +     depends on (ISA && ISA_DMA_API) || EISA || PCI
> 
> I thought the desire was to avoid a compile failure when ISA && !
> ISA_DMA_API?  Won't this one fail if ISA is defined with either EISA or
> PCI and !ISA_DMA_API?

I thought I had it ruled out, but now I've actually found a combination:
we can build an ARM kernel that supports two ancient machines, and one
of them supports ISA (but not ISA_DMA_API), while the other one supports
PCI. I had looked through several thousand randconfig builds and not
found this combination together with advansys, but I guess that is
because those were mostly old builds from the times when there was
a dependency on VIRT_TO_BUS that this platform doesn't have.

So screw this one and go back to the original patch.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] scsi: advansys needs ISA dma api for ISA support Arnd Bergmann <arnd@arndb.de> - 2015-10-16 14:20 +0200
  Re: [PATCH v2] scsi: advansys needs ISA dma api for ISA support Hannes Reinecke <hare@suse.de> - 2015-10-16 14:20 +0200
  Re: [PATCH v2] scsi: advansys needs ISA dma api for ISA support James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-10-16 16:00 +0200
    Re: [PATCH v2] scsi: advansys needs ISA dma api for ISA support Arnd Bergmann <arnd@arndb.de> - 2015-10-16 16:20 +0200
      Re: [PATCH v2] scsi: advansys needs ISA dma api for ISA support James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-10-16 16:30 +0200

csiph-web