Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1248691

Re: [PATCH v2] scsi: advansys needs ISA dma api for ISA support

Show all headers | View raw

On 10/16/2015 02:13 PM, Arnd Bergmann wrote:
> The advansys drvier uses the request_dma function that is used on ISA
> machines for the internal DMA controller, which causes build errors
> on platforms that have ISA slots but do not provide the ISA DMA API:
> 
> drivers/scsi/advansys.c: In function 'advansys_board_found':
> drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration]
> 
> The problem now showed up in ARM randconfig builds after commit
> 6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation
> warning") made it possible to build on platforms that have neither
> VIRT_TO_BUS nor ISA_DMA_API but that do have ISA.
> 
> This adds a dependency to only build the driver on ISA based machines
> if they also support ISA_DMA_API, or if they EISA or PCI are also
> enabled.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] scsi: advansys needs ISA dma api for ISA support Arnd Bergmann <arnd@arndb.de> - 2015-10-16 14:20 +0200
  Re: [PATCH v2] scsi: advansys needs ISA dma api for ISA support Hannes Reinecke <hare@suse.de> - 2015-10-16 14:20 +0200
  Re: [PATCH v2] scsi: advansys needs ISA dma api for ISA support James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-10-16 16:00 +0200
    Re: [PATCH v2] scsi: advansys needs ISA dma api for ISA support Arnd Bergmann <arnd@arndb.de> - 2015-10-16 16:20 +0200
      Re: [PATCH v2] scsi: advansys needs ISA dma api for ISA support James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-10-16 16:30 +0200

csiph-web