Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1248758

Re: [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

Show all headers | View raw

On Fri, Oct 16, 2015 at 8:06 AM, Mark Rutland <mark.rutland@arm.com> wrote:
>> +     /* FIXME - use of_graph_get_port_by_id(np, 1) on newer kernels */
>> +     in_ep = of_graph_get_next_endpoint(np, NULL);
>
> Huh?
>
>> +     edidp = of_get_property(np, "edid", &size);
>
> This property wasn't mentioned in the binding document.
>
> Please describe it. If it's from a more generic binding, refer to that
> from the binding document.

It should be generic, but currently documented in individual drivers.
I also think this is not the right location in the DT for this
property. It should be part of the panel or connector node instead.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT properties CK Hu <ck.hu@mediatek.com> - 2015-10-16 14:20 +0200
  [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge CK Hu <ck.hu@mediatek.com> - 2015-10-16 14:20 +0200
    Re: [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge Mark Rutland <mark.rutland@arm.com> - 2015-10-16 15:10 +0200
      Re: [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge Rob Herring <robh+dt@kernel.org> - 2015-10-16 15:30 +0200
    Re: [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge kbuild test robot <lkp@intel.com> - 2015-10-16 16:00 +0200
    [PATCH] drm/bridge: fix platform_no_drv_owner.cocci warnings kbuild test robot <lkp@intel.com> - 2015-10-16 16:00 +0200
  Re: [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT  properties Philipp Zabel <p.zabel@pengutronix.de> - 2015-10-16 15:10 +0200
  Re: [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT  properties Mark Rutland <mark.rutland@arm.com> - 2015-10-16 15:10 +0200
  Re: [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT properties Rob Herring <robh+dt@kernel.org> - 2015-10-16 15:30 +0200

csiph-web