Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1248731

Re: [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT properties

Show all headers | View raw

Hi CK,

there is a typo in the subject: s/Dcumentation/Documentation/.

Am Freitag, den 16.10.2015, 20:15 +0800 schrieb CK Hu:
> From: Jitao Shi <jitao.shi@mediatek.com>
> 
> Add documentation for DT properties supported by ps8640
> DSI-eDP converter.
> 
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
[...]
> +	- ps8640-1v2-supply: OF device-tree regulator specification for 1v2.
> +	- ps8640-3v3-supply: OF device-tree regulator specification for 3v3.

The ps8640- part of the regulator supply property names is redundant.
The PS8622 driver uses vdd12-supply as its regulator. Should we strive
for consistency here? Or if you have access to the datasheet, how are
these inputs called there?

> +
> +Optional properties:
> +	- video interfaces: Device node can contain video interface port
> +			    nodes for panel according to [1].
> +
> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt

It should be documented here that port@0 is the input port and port@1 is
the output port.

best regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT properties CK Hu <ck.hu@mediatek.com> - 2015-10-16 14:20 +0200
  [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge CK Hu <ck.hu@mediatek.com> - 2015-10-16 14:20 +0200
    Re: [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge Mark Rutland <mark.rutland@arm.com> - 2015-10-16 15:10 +0200
      Re: [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge Rob Herring <robh+dt@kernel.org> - 2015-10-16 15:30 +0200
    Re: [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge kbuild test robot <lkp@intel.com> - 2015-10-16 16:00 +0200
    [PATCH] drm/bridge: fix platform_no_drv_owner.cocci warnings kbuild test robot <lkp@intel.com> - 2015-10-16 16:00 +0200
  Re: [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT  properties Philipp Zabel <p.zabel@pengutronix.de> - 2015-10-16 15:10 +0200
  Re: [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT  properties Mark Rutland <mark.rutland@arm.com> - 2015-10-16 15:10 +0200
  Re: [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT properties Rob Herring <robh+dt@kernel.org> - 2015-10-16 15:30 +0200

csiph-web