Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1248682

Re: [PATCH] ipv6: no addrconf for slave devices

Show all headers | View raw

On Fri, Oct 16, 2015, at 13:54, Jiri Pirko wrote:
> Fri, Oct 16, 2015 at 12:21:51PM CEST, jblunck@infradead.org wrote:
> >If a device without the IFF_SLAVE flag set (e.g. team, bridge, openvswitch
> >vport, batman) is enslaved and IPv6 is active then addrconf will be
> >initiated and a link-local address is added to the slave interface.
> >
> >This patch alters the behavior so that addrconf will only run on the master
> >device itself. This is achieved by checking the device tree instead of
> >checking for a specific flag.
> >
> >Signed-off-by: Jan Blunck <jblunck@infradead.org>
> >---
> > net/ipv6/addrconf.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> >diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> >index 9001133..26d61f0 100644
> >--- a/net/ipv6/addrconf.c
> >+++ b/net/ipv6/addrconf.c
> >@@ -3141,8 +3141,12 @@ static int addrconf_notify(struct notifier_block *this, unsigned long event,
> > 
> > 	case NETDEV_UP:
> > 	case NETDEV_CHANGE:
> >-		if (dev->flags & IFF_SLAVE)
> >+		/* If a master is set stop IPv6 on this interface */
> >+		if (netdev_master_upper_dev_get(dev)) {
> >+			if (idev)
> >+				addrconf_ifdown(dev, 1);
> 
> This breaks teamd if it's using NS/NA ping link-watch on link-local
> addresses.
> 
> What is the reason for this patch? Does it recolve any issue you are
> having?

I also feel uncomfortable with this change.

We can probably never change this behavior, ever. User space might
expect LL addresses on slave devices already. Same question as Jiri,
what was the motivation for this patch?

Bye,
Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ipv6: no addrconf for slave devices Jan Blunck <jblunck@infradead.org> - 2015-10-16 12:30 +0200
  Re: [PATCH] ipv6: no addrconf for slave devices Jiri Pirko <jiri@resnulli.us> - 2015-10-16 14:00 +0200
    Re: [PATCH] ipv6: no addrconf for slave devices Hannes Frederic Sowa <hannes@stressinduktion.org> - 2015-10-16 14:20 +0200
    Re: [PATCH] ipv6: no addrconf for slave devices Jan Blunck <jblunck@infradead.org> - 2015-10-16 18:00 +0200
      Re: [PATCH] ipv6: no addrconf for slave devices David Ahern <dsa@cumulusnetworks.com> - 2015-10-16 18:10 +0200
        Re: [PATCH] ipv6: no addrconf for slave devices Jan Blunck <jblunck@infradead.org> - 2015-10-16 18:20 +0200
          Re: [PATCH] ipv6: no addrconf for slave devices David Ahern <dsa@cumulusnetworks.com> - 2015-10-16 18:20 +0200
            Re: [PATCH] ipv6: no addrconf for slave devices Jan Blunck <jblunck@infradead.org> - 2015-10-16 18:40 +0200

csiph-web