Re: [PATCH 1/5] ftrace: remove redundant strsep in mod_callback

From	Dmitry Safonov <0x7f454c46@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] ftrace: remove redundant strsep in mod_callback
Date	2015-10-16 11:00 +0200
Message-ID	<qk91M-1e0-5@gated-at.bofh.it> (permalink)
References	<qe6gh-3Gy-9@gated-at.bofh.it> <qjiAa-6Mx-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2015-10-14 3:48 GMT+03:00 Steven Rostedt <rostedt@goodmis.org>:
>> -     ret = ftrace_match_module_records(hash, func, mod);
>> -     if (!ret)
>> -             ret = -EINVAL;
>> +     ret = ftrace_match_module_records(hash, func, param);
>> +     if (ret == 0)
>
> Small nit, personally, I prefer the if (!ret) version.
>
> For me "== 0" is for counters and strcmp. I may change this to be
> consistent with the rest of the code.
>
> -- Steve
Ok, I thought "== 0" will be more readable near comparison "< 0",
but anyway, (!ret) is good.

>
>> +             return -EINVAL;
>>       if (ret < 0)
>>               return ret;
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/5] ftrace: remove redundant strsep in mod_callback Steven Rostedt <rostedt@goodmis.org> - 2015-10-14 03:00 +0200
  Re: [PATCH 1/5] ftrace: remove redundant strsep in mod_callback Dmitry Safonov <0x7f454c46@gmail.com> - 2015-10-16 11:00 +0200

csiph-web